Types for the package "dkfds" #74058
Conversation
|
@chcederquist Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74058,
"author": "chcederquist",
"headCommitOid": "2f47b1a477f56aa41b5cd6c0bf8c0985fe631384",
"mergeBaseOid": "63fb66ad8f734645656608804cf17199a67830d5",
"lastPushDate": "2025-11-10T20:18:00.000Z",
"lastActivityDate": "2025-11-14T19:03:25.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "dkfds",
"kind": "add",
"files": [
{
"path": "types/dkfds/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/dkfds/dkfds-tests.ts",
"kind": "test"
},
{
"path": "types/dkfds/index.d.ts",
"kind": "definition"
},
{
"path": "types/dkfds/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/dkfds/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"chcederquist"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "changereq",
"reviewer": "andrewbranch",
"date": "2025-11-14T19:03:25.000Z"
}
],
"mainBotCommentID": 3513744740,
"ciResult": "pass"
} |
|
🔔 @chcederquist — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
There was a problem hiding this comment.
The JS code is published as a UMD module, so you also need to add
export = DKFDS;
export as namespace DKFDS;This tells TypeScript that the namespace can be used as a global or imported as a CJS module.
|
@chcederquist One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you! |
Please fill in this template.
Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change.
Follow the advice from the readme.
Avoid common mistakes.
Run
pnpm test <package to test>.The package does not already provide its own types, or cannot have its
.d.tsfiles generated via--declarationIf this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
Create it with
dts-gen --dt, not by basing it on an existing project.Represents shape of module/library correctly
tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.