这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@simonrey1
Copy link

@simonrey1 simonrey1 commented Nov 6, 2025

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 6, 2025

@simonrey1 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 10 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74029,
  "author": "simonrey1",
  "headCommitOid": "71bb2262bf0d39ec94ef806d02e011bae86c5885",
  "mergeBaseOid": "2243b87255f228f1052ba457c4eaed37dce55047",
  "lastPushDate": "2025-11-06T14:27:34.000Z",
  "lastActivityDate": "2025-11-06T14:27:34.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "dockerode",
      "kind": "edit",
      "files": [
        {
          "path": "types/dockerode/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "seikho",
        "nlaplante",
        "isac322",
        "lazarusx",
        "meisenzahl",
        "thegecko",
        "CameronDiver",
        "p4sca1",
        "userlerueda"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 3497515769,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

Hey @simonrey1,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Contributor

🔔 @Seikho @nlaplante @isac322 @LazarusX @meisenzahl @thegecko @CameronDiver @P4sca1 @userlerueda — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Critical package Untested Change This PR does not touch tests

Projects

Status: Needs Maintainer Review

Development

Successfully merging this pull request may close these issues.

2 participants