@jgabriel98 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

• instafeed.js — on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• 🕐 Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 11 days — please try to get reviewers!

{
  "type": "info",
  "now": "-",
  "pr_number": 74018,
  "author": "jgabriel98",
  "headCommitOid": "4836d64b258276f6fd8458fab890d9e73519c973",
  "mergeBaseOid": "52da2c9cc45f32dd0b0727e0d39ad0f9db301080",
  "lastPushDate": "2025-11-04T16:23:59.000Z",
  "lastActivityDate": "2025-11-09T22:40:42.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "instafeed.js",
      "kind": "edit",
      "files": [
        {
          "path": "types/instafeed.js/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/instafeed.js/instafeed.js-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "IncognitaDev"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "IncognitaDev",
      "date": "2025-11-04T16:42:54.000Z",
      "abbrOid": "0990a1a"
    }
  ],
  "mainBotCommentID": 3486875680,
  "ciResult": "pass"
}

🔔 @IncognitaDev — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

thx for the contribution, i will probably change it to be a generic sooner, but this is already a good fix.

can you add a test for this case? @jgabriel98

can you add a test for this case? @jgabriel98

@IncognitaDev i can try mas probably will fail: i'm eye baling this fix.
In other words: i did not make a local fork and pulled the repository, i just edited the file directly on github website, since the fix was simple.

My last commit is an attempt of adding a test. But if it fail, i wont be able to help more, because i'm actually running it on a remote raspberry pi, and it wont be able to handle such a huge repository 😞

@jgabriel98 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

Yep,
i'm unable to write/validate good tests with having to setup WSL2 on my machine.

@IncognitaDev Do you mind doing it so for me?
(by directly commiting into this PR, or by sending me the test code then i commit it myself).

Sorry for the trouble!

@jgabriel98 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@jgabriel98 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@jgabriel98 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@IncognitaDev Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@IncognitaDev Do you mind doing it so for me?

yep, i can do it soon

@IncognitaDev Do you mind doing it so for me?

yep, i can do it soon

@IncognitaDev no need anymore!
i've got it after some trial & error (pushing many times and seeing the github actions result). So there's no need anymore (but thanks anyway!)

Also, i've changed the PR to actually correctly use type Templating, like you wished for:

now, all the callbacks/hooks returns and parameter are integrated!

@jgabriel98 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

hey @IncognitaDev,
is there anything left to getting a approval on this PR?

Re-ping @IncognitaDev:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!