Add gutterBreakPoints property to index.d.ts for react-responsive-masonry #74015
Conversation
|
@alifeinbinary Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. InactiveThis PR has been inactive for 12 days — please try to get reviewers! Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 74015,
"author": "alifeinbinary",
"headCommitOid": "c774e75f8e2e086c170636964de04d259eb462bf",
"mergeBaseOid": "ff41535d2d84f62f459fa56a9c462182ed9d1ab3",
"lastPushDate": "2025-11-04T04:28:32.000Z",
"lastActivityDate": "2025-11-04T04:52:30.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "react-responsive-masonry",
"kind": "edit",
"files": [
{
"path": "types/react-responsive-masonry/index.d.ts",
"kind": "definition"
},
{
"path": "types/react-responsive-masonry/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/react-responsive-masonry/react-responsive-masonry-tests.tsx",
"kind": "test"
}
],
"owners": [
"themashcodee"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 3483708515,
"ciResult": "pass"
} |
|
🔔 @themashcodee — please review this PR in the next few days. Be sure to explicitly select |
|
@alifeinbinary The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@alifeinbinary The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
|
@alifeinbinary The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
Added documentation for gutterBreakPoints property.
|
Re-ping @themashcodee: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
Addresses issue:
cedricdelpoux/react-responsive-masonry#141
According to the documentation here: https://github.com/cedricdelpoux/react-responsive-masonry
the ResponsiveMasonry component should allow for gutterBreakpoints as an optional property but no such definition is provided in the current type definitions.
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
package.json.