这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@ralphr123
Copy link

Please fill in this template.

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an npm package, match the name. If not, do not conflict with the name of an npm package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 3, 2025

@ralphr123 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74013,
  "author": "ralphr123",
  "headCommitOid": "9eba44f4242225cbe4c4339aafb5874680908dd2",
  "mergeBaseOid": "6fb1e4731681a6aab2cda4df1e5d9e9bc7ef01dd",
  "lastPushDate": "2025-11-03T21:26:16.000Z",
  "lastActivityDate": "2025-11-14T18:58:34.000Z",
  "mergeOfferDate": "2025-11-14T18:59:14.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "zerobounce__zero-bounce-sdk",
      "kind": "add",
      "files": [
        {
          "path": "types/zerobounce__zero-bounce-sdk/.npmignore",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/zerobounce__zero-bounce-sdk/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/zerobounce__zero-bounce-sdk/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/zerobounce__zero-bounce-sdk/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/zerobounce__zero-bounce-sdk/zerobounce__zero-bounce-sdk-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [],
      "addedOwners": [
        "ralphr123"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "andrewbranch",
      "date": "2025-11-14T18:58:34.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 3482673050,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label Nov 3, 2025
@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Nov 3, 2025
@typescript-bot
Copy link
Contributor

🔔 @ralphr123 — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@DangerBotOSS
Copy link

Formatting

The following files are not formatted:

  1. types/zerobounce__zero-bounce-sdk/zerobounce__zero-bounce-sdk-tests.ts
  2. types/zerobounce__zero-bounce-sdk/index.d.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against 9eba44f

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in Pull Request Status Board Nov 3, 2025
@ralphr123 ralphr123 changed the title Ralph/zerobounce zero bounce sdk Add @zerobounce/zero-bounce-sdk type definitions Nov 3, 2025
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Nov 14, 2025
@typescript-bot
Copy link
Contributor

@ralphr123: Everything looks good here. I am ready to merge this PR (at 9eba44f) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in Pull Request Status Board Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Approved New Definition This PR creates a new definition package. Self Merge This PR can now be self-merged by the PR author or an owner

Projects

Status: Waiting for Author to Merge

Development

Successfully merging this pull request may close these issues.

4 participants