这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@jleatherwood
Copy link

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 2, 2025

@jleatherwood Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by type definition owners, DT maintainers or others

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 15 days — please try to get reviewers!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 74003,
  "author": "jleatherwood",
  "headCommitOid": "67e51968c6d8a1d70acc398bf3c2de497a0babcb",
  "mergeBaseOid": "61b037700fc4a20c4481f6005459d51ccf63991d",
  "lastPushDate": "2025-11-02T16:34:36.000Z",
  "lastActivityDate": "2025-11-02T16:34:36.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "aws-cloudfront-function",
      "kind": "edit",
      "files": [
        {
          "path": "types/aws-cloudfront-function/aws-cloudfront-function-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/aws-cloudfront-function/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "bukka"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 3478092731,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @bukka — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Nov 2, 2025
@typescript-bot
Copy link
Contributor

Re-ping @bukka:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer.

Projects

Status: Waiting for Code Reviews

Development

Successfully merging this pull request may close these issues.

2 participants