这是indexloc提供的服务,不要输入任何密码
Skip to content

[office-js][office-js-preview] (Outlook) Correct the recipients limit note for the setAsync method #73328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samantharamon
Copy link
Contributor

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 24, 2025

@samantharamon Thank you for submitting this PR!

This is a live comment that I will keep updated.

2 packages in this PR

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes that affect more than one package

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 73328,
  "author": "samantharamon",
  "headCommitOid": "95e698d29723656f0c7832cadbf18798b2dfb5da",
  "mergeBaseOid": "f7a11926075f054459792e719cdb72311e86f271",
  "lastPushDate": "2025-07-24T22:01:33.000Z",
  "lastActivityDate": "2025-07-24T22:10:52.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "office-js-preview",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js-preview/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "alison-mk",
        "samantharamon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "office-js",
      "kind": "edit",
      "files": [
        {
          "path": "types/office-js/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "OfficeDev",
        "Rick-Kirkham",
        "AlexJerabek",
        "ElizabethSamuel-MSFT",
        "alison-mk",
        "samantharamon"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Rick-Kirkham",
      "date": "2025-07-24T22:10:52.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 3115111525,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Edits multiple packages Author is Owner The author of this PR is a listed owner of the package. Untested Change This PR does not touch tests labels Jul 24, 2025
@typescript-bot
Copy link
Contributor

Hey @samantharamon,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Jul 24, 2025
@typescript-bot
Copy link
Contributor

🔔 @OfficeDev @Rick-Kirkham @AlexJerabek @ElizabethSamuel-MSFT @alison-mk — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Jul 24, 2025
@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Edits multiple packages Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests
Projects
Status: Needs Maintainer Review
Development

Successfully merging this pull request may close these issues.

3 participants