-
Notifications
You must be signed in to change notification settings - Fork 30.4k
[office-js][office-js-preview] (Outlook) Correct the recipients limit note for the setAsync method #73328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[office-js][office-js-preview] (Outlook) Correct the recipients limit note for the setAsync method #73328
Conversation
@samantharamon Thank you for submitting this PR! This is a live comment that I will keep updated. 2 packages in this PR
Code ReviewsBecause this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 73328,
"author": "samantharamon",
"headCommitOid": "95e698d29723656f0c7832cadbf18798b2dfb5da",
"mergeBaseOid": "f7a11926075f054459792e719cdb72311e86f271",
"lastPushDate": "2025-07-24T22:01:33.000Z",
"lastActivityDate": "2025-07-24T22:10:52.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Popular",
"pkgInfo": [
{
"name": "office-js-preview",
"kind": "edit",
"files": [
{
"path": "types/office-js-preview/index.d.ts",
"kind": "definition"
}
],
"owners": [
"OfficeDev",
"Rick-Kirkham",
"AlexJerabek",
"ElizabethSamuel-MSFT",
"alison-mk",
"samantharamon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
},
{
"name": "office-js",
"kind": "edit",
"files": [
{
"path": "types/office-js/index.d.ts",
"kind": "definition"
}
],
"owners": [
"OfficeDev",
"Rick-Kirkham",
"AlexJerabek",
"ElizabethSamuel-MSFT",
"alison-mk",
"samantharamon"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Popular"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "Rick-Kirkham",
"date": "2025-07-24T22:10:52.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 3115111525,
"ciResult": "pass"
} |
Hey @samantharamon, 😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module. This can potentially save days of time for you! |
🔔 @OfficeDev @Rick-Kirkham @AlexJerabek @ElizabethSamuel-MSFT @alison-mk — please review this PR in the next few days. Be sure to explicitly select |
pnpm test <package to test>
.If changing an existing definition:
package.json
.