这是indexloc提供的服务,不要输入任何密码
Skip to content

Add xMailer to Mail.Options for nodemailer #73327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cloverb
Copy link

@cloverb cloverb commented Jul 24, 2025

Please fill in this template.

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 24, 2025

@cloverb Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Most recent commit is approved by a DT maintainer

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 73327,
  "author": "cloverb",
  "headCommitOid": "948f3954edd7a80e5655d83caaa00212117d4edc",
  "mergeBaseOid": "f7a11926075f054459792e719cdb72311e86f271",
  "lastPushDate": "2025-07-24T18:04:00.000Z",
  "lastActivityDate": "2025-07-24T19:44:28.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "nodemailer",
      "kind": "edit",
      "files": [
        {
          "path": "types/nodemailer/lib/mailer/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/nodemailer/nodemailer-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/nodemailer/v3/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "rogierschouten",
        "dex4er",
        "bioball"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 3114372566,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @rogierschouten @dex4er @bioball — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Jul 24, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Pull Request Status Board Jul 24, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Jul 24, 2025
@hkleungai
Copy link
Contributor

Just a note: This PR is in conflict with my #73297, which was opened few days ago.

I am trying to remove the entire v3 in my PR while making the v6 & v7 update, because v3 is basically a very old version with very low usage (based on npm stat), but I can see you make an update to v3 types.

I am leaving this comment for myself, so that github can notify me on which of our PR will get merged first, then one of us may need to update the PR on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Maintainer Review
Development

Successfully merging this pull request may close these issues.

4 participants