这是indexloc提供的服务,不要输入任何密码
Skip to content

mark ZOUTOFMEMORY as keeper hardware error #84420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025

Conversation

hanfei1991
Copy link
Member

@hanfei1991 hanfei1991 commented Jul 24, 2025

SharedMergeTree will check the error type, it should either be hardware error or user error, otherwise it will throw logical error. See https://github.com/ClickHouse/clickhouse-core-incidents/issues/877

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

make ZOUTOFMEMORY hardware error, otherwise it will throw logical error. See https://github.com/ClickHouse/clickhouse-core-incidents/issues/877

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Copy link

clickhouse-gh bot commented Jul 25, 2025

Workflow [PR], commit [3dd0499]

Summary:

job_name test_name status info comment
Build (arm_v80compat) error
Build (ppc64le) error

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 25, 2025
@GrigoryPervakov GrigoryPervakov self-assigned this Jul 25, 2025
Copy link
Contributor

@GrigoryPervakov GrigoryPervakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we backport that?

@hanfei1991 hanfei1991 added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Jul 25, 2025
@hanfei1991 hanfei1991 enabled auto-merge July 25, 2025 13:49
@hanfei1991 hanfei1991 added this pull request to the merge queue Jul 25, 2025
Merged via the queue into ClickHouse:master with commit cab7eaf Jul 25, 2025
361 of 366 checks passed
@hanfei1991 hanfei1991 deleted the hanfei/fix_keeper_error_code branch July 25, 2025 14:01
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 25, 2025
@robot-ch-test-poll2 robot-ch-test-poll2 added pr-backports-created-cloud pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Jul 25, 2025
robot-clickhouse-ci-2 added a commit that referenced this pull request Jul 25, 2025
Cherry pick #84420 to 25.3: mark ZOUTOFMEMORY as keeper hardware error
robot-clickhouse-ci-2 added a commit that referenced this pull request Jul 25, 2025
Cherry pick #84420 to 25.4: mark ZOUTOFMEMORY as keeper hardware error
robot-clickhouse-ci-2 added a commit that referenced this pull request Jul 25, 2025
Cherry pick #84420 to 25.5: mark ZOUTOFMEMORY as keeper hardware error
robot-clickhouse-ci-2 added a commit that referenced this pull request Jul 25, 2025
Cherry pick #84420 to 25.6: mark ZOUTOFMEMORY as keeper hardware error
robot-clickhouse-ci-2 added a commit that referenced this pull request Jul 25, 2025
Cherry pick #84420 to 25.7: mark ZOUTOFMEMORY as keeper hardware error
hanfei1991 added a commit that referenced this pull request Jul 25, 2025
Cherry pick #84420 to 24.8: mark ZOUTOFMEMORY as keeper hardware error
@hanfei1991 hanfei1991 added pr-bugfix Pull request with bugfix, not backported by default and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Jul 25, 2025
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 25, 2025
clickhouse-gh bot added a commit that referenced this pull request Jul 25, 2025
Backport #84420 to 25.7: mark ZOUTOFMEMORY as keeper hardware error
clickhouse-gh bot added a commit that referenced this pull request Jul 25, 2025
Backport #84420 to 25.6: mark ZOUTOFMEMORY as keeper hardware error
alexey-milovidov added a commit that referenced this pull request Jul 25, 2025
Backport #84420 to 25.5: mark ZOUTOFMEMORY as keeper hardware error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants