这是indexloc提供的服务,不要输入任何密码
Skip to content

Improve interactive client: replace tab characters with spaces #84412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xiaohuanlin
Copy link

@xiaohuanlin xiaohuanlin commented Jul 24, 2025

  • Use modify_callback in ReplxxLineReader to handle tab characters
  • Convert tabs to spaces during text input to improve terminal formatting
  • Fixes issue with tab display in pasted SQL queries

Changelog category (leave one):

  • Improvement

Changelog entry (a user-friendly description of your change):

Replace tab characters with spaces when pasting in interactive clickhouse-client. Closes #83922

…asting

- Use modify_callback in ReplxxLineReader to handle tab characters
- Convert tabs to spaces during text input to improve terminal formatting
- Fixes issue with tab display in pasted SQL queries

Closes ClickHouse#83922
@CLAassistant
Copy link

CLAassistant commented Jul 24, 2025

CLA assistant check
All committers have signed the CLA.

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Jul 24, 2025
Copy link

clickhouse-gh bot commented Jul 24, 2025

Workflow [PR], commit [9df241d]

Summary:
15 failures out of 105 shown:

job_name test_name status info comment
Style check failure
cpp failure
Build (amd_debug) dropped
Build (amd_release) dropped
Build (amd_asan) dropped
Build (amd_tsan) dropped
Build (amd_msan) dropped
Build (amd_ubsan) dropped
Build (amd_binary) dropped
Build (arm_release) dropped
Build (arm_asan) dropped
Build (arm_coverage) dropped
Build (arm_binary) dropped
Build (amd_darwin) dropped
Build (arm_darwin) dropped
Build (arm_v80compat) dropped

@xiaohuanlin
Copy link
Author

Already changed PR desc, please help me rerun the test

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Jul 26, 2025
@alexey-milovidov alexey-milovidov self-assigned this Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I don't like how Tab character is pasted into an interactive clickhouse-client session
3 participants