Bump curl from 8.14.0 to 8.15.0 #84231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Workflow [PR], commit [d9f9115] Summary: ❌
|
799a1ff to
46bb78b
Compare
contrib/curl-cmake/curl_config.h
Outdated
| @@ -44,8 +44,8 @@ | |||
| #define HAVE_FCNTL_H | |||
| #define HAVE_NETDB_H | |||
| #define HAVE_NETINET_IN_H | |||
| #define HAVE_SELECT | |||
There was a problem hiding this comment.
This can be problematic. Where is it used?
There was a problem hiding this comment.
It became mandatory as per curl 8.15.0 (used by "lib/curlx/wait.c" which does
#ifndef HAVE_SELECT
#error "We cannot compile without select() support."
#endifand uses timeval in a wait function). It should be fine though, we include the same header from poco and c-ares already on all platforms.
|
Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel):
Integration tests (release, 3/4):
|
alexey-milovidov
approved these changes
Jul 23, 2025
Merged
via the queue into
ClickHouse:master
with commit Jul 23, 2025
52750a6
120 of 123 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Bumped internal curl from 8.14.0 to 8.15.0