Move getMergeTreeReaderSettings to a static member function #83531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* src/Storages/MergeTree/MergeTreeIOSettings.{h,cpp} (MergeTreeReaderSettings::Create) : New replacement function
Update all the occurrences
* src/Processors/QueryPlan/ReadFromMergeTree.cpp (getMergeTreeReaderSettings) : Removed function
|
Workflow [PR], commit [4351af2] Summary: ❌
|
rschu1ze
approved these changes
Jul 9, 2025
rschu1ze
reviewed
Jul 9, 2025
|
@Ergus Merge from master to resolve merge conflicts, then lets try to merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an internal minor change to make the
MergeTreeReaderSettingscreation a bit more consistent.This creates a new static function to substitute the
getMergeTreeReaderSettingsbecause that creator will be needed in a different location.Changelog category (leave one):