Update passedElement.value after removing item #1317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a830b8e to
59e8e4f
Compare
Xon
requested changes
Jul 9, 2025
There was a problem hiding this comment.
This change doesn't look to work with select backed fields. The root-cause is this._store.withTxn is deferring the backing element update to after the method finishes, but the events are raised inside the method.
The correct solution would be to move the events to after the withTxn() method call. There looks to be a bunch of locations which need to be updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the problem arose because of the wrapper this._store.withTxn(function () {}). I compared the working version of 10 choices and 11 (with this bug) and here is the problem. See the screenshots below.
When we click on the 'X' to remove the "Second" tag, we get, for version 11 (with bug):
As you can see, after deleting item, the passedElement.value field does not change its value (second is not deleted)
Compare this to working version 10:
As you see after removal "second" passedElement.value changed and contains only "first" value.
Types of changes
Checklist