feat: wallet balance component #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31d34cd to
1d6a9b3
Compare
8ca25a5 to
d79362d
Compare
9b13406 to
d7e4c34
Compare
krzysu
commented
Dec 10, 2024
| * @returns boolean | ||
| * @returns void | ||
| * | ||
| * TODO: this endpoint doesn't work, returns TypeError: Only absolute URLs are supported |
Contributor
There was a problem hiding this comment.
but it works in tests.
describe('Faucet Api', () => {
const faucetApi = new FaucetApi(apikey, BASE_URL);
it('Request native token', async () => {
const res = await faucetApi.request({
blockchain: BLOCKCHAIN.ETH_SEPOLIA,
address: ETH_SEPOLIA_WALLET_ADDRESS,
native: true,
});
expect(res).toBe(true);
});
it('Request eurc token', async () => {
const res = await faucetApi.request({
blockchain: BLOCKCHAIN.ETH_SEPOLIA,
address: ETH_SEPOLIA_WALLET_ADDRESS,
eurc: true,
});
expect(res).toBe(true);
});
it('Request usdc token', async () => {
const res = await faucetApi.request({
blockchain: BLOCKCHAIN.ETH_SEPOLIA,
address: ETH_SEPOLIA_WALLET_ADDRESS,
usdc: true,
});
expect(res).toBe(true);
});
});
Contributor
There was a problem hiding this comment.
I will change to void in next PR
Contributor
Author
There was a problem hiding this comment.
I tested it from just a simple node script and faucet works fine, so it must be something with remix then, I will investigate, sorry.
you can keep boolean return, there was a bug with 'wallet' part though in here, no?
------------------------------------------------------ ⬇️ (unnecessary)
await this.postRequest<void>('/faucet/drips', params, 'wallets')
Contributor
Author
There was a problem hiding this comment.
after pulling latest version from main it also works in the webapp, seems you fixed something in your last PR 😄
krzysu
commented
Dec 10, 2024
| async balance(params: WalletBalanceParameters): Promise<WalletTokenBalance[]> { | ||
| const { id, ...rest } = params; | ||
| return this.getRequest<WalletTokenBalances>( | ||
| return this.getRequest<WalletTokenBalance[]>( |
avkos
approved these changes
Dec 10, 2024
d00025c to
715535c
Compare
715535c to
bc628f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56
Closes #25