feat: package usability changes #123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzysu
reviewed
Feb 5, 2025
| export * from './components/WalletSetDetails'; | ||
| export * as formats from './lib/format'; | ||
| export * as utils from './lib/utils'; | ||
| export * from './styles/tailwind.preset'; |
Contributor
There was a problem hiding this comment.
notice that preset has its own build step and export settings to not mix up the configuration with usage, see packages/circle-react-elements/package.json
krzysu
reviewed
Feb 5, 2025
| import tailwindAnimate from 'tailwindcss-animate'; | ||
|
|
||
| const preset = { | ||
| export const tailwindPreset = { |
Contributor
There was a problem hiding this comment.
I suggest to use more package-name related name here as consumer could use multiple presets in their app, so circleElementsPreset would be more accurate
Contributor
|
I upgraded tailwind css to v4 so this PR won't be needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.