Fixing sample script comments #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>
Fixing sample script comments as they were set to 1155 instead of 721
rob1997
approved these changes
Apr 30, 2024
kantagara
approved these changes
Apr 30, 2024
oleksandrchainsafe
approved these changes
Apr 30, 2024
sneakzttv
added a commit
that referenced
this pull request
Apr 30, 2024
* contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Fixing sample script comments (#930) * Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Fixing sample script comments Fixing sample script comments as they were set to 1155 instead of 721 --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Ramp fix (#931) * Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Ramp fix Fixed ramp via conditional compilation to avoid changing the folder structure of samples. * Amending Cleaner implementation of compilation directives * Amend Amend --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Sneakz/typo fix (#933) Update DisableGameObjectIfServiceNotActive.cs * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
sneakzttv
added a commit
that referenced
this pull request
Apr 30, 2024
* contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Fixing sample script comments (#930) * Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Fixing sample script comments Fixing sample script comments as they were set to 1155 instead of 721 --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Ramp fix (#931) * Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Ramp fix Fixed ramp via conditional compilation to avoid changing the folder structure of samples. * Amending Cleaner implementation of compilation directives * Amend Amend --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Sneakz/typo fix (#933) Update DisableGameObjectIfServiceNotActive.cs * Removing Sygma from ILoginProvider * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Update ILoginProvider.cs --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> Co-authored-by: Nikola Garabandic <kantagara@gmail.com> Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
rob1997
added a commit
that referenced
this pull request
Jan 16, 2025
* Fixes to stabilize the head (#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (#922) * Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Fixing sample script comments Fixing sample script comments as they were set to 1155 instead of 721 --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>
sergeypanin1994
pushed a commit
to sergeypanin1994/web3.unity
that referenced
this pull request
Mar 16, 2025
* Fixes to stabilize the head (ChainSafe#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (ChainSafe#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (ChainSafe#922) * Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (ChainSafe#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Fixing sample script comments Fixing sample script comments as they were set to 1155 instead of 721 --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>
sergeypanin1994
pushed a commit
to sergeypanin1994/web3.unity
that referenced
this pull request
Mar 16, 2025
* contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (ChainSafe#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (ChainSafe#922) * Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (ChainSafe#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Fixing sample script comments (ChainSafe#930) * Fixes to stabilize the head (ChainSafe#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (ChainSafe#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (ChainSafe#922) * Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (ChainSafe#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Fixing sample script comments Fixing sample script comments as they were set to 1155 instead of 721 --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Ramp fix (ChainSafe#931) * Fixes to stabilize the head (ChainSafe#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (ChainSafe#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (ChainSafe#922) * Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (ChainSafe#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Ramp fix Fixed ramp via conditional compilation to avoid changing the folder structure of samples. * Amending Cleaner implementation of compilation directives * Amend Amend --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Sneakz/typo fix (ChainSafe#933) Update DisableGameObjectIfServiceNotActive.cs * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
sergeypanin1994
pushed a commit
to sergeypanin1994/web3.unity
that referenced
this pull request
Mar 16, 2025
* contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (ChainSafe#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (ChainSafe#922) * Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (ChainSafe#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Fixing sample script comments (ChainSafe#930) * Fixes to stabilize the head (ChainSafe#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (ChainSafe#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (ChainSafe#922) * Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (ChainSafe#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Fixing sample script comments Fixing sample script comments as they were set to 1155 instead of 721 --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Ramp fix (ChainSafe#931) * Fixes to stabilize the head (ChainSafe#927) * contribution edits * condition to run tests fixed * typo fix * use deploy key for push * bot makes push instead of actor * fixed syntax * setup ssh keys added * different way for setting up ssh * only play mode tests * reverted ssh setup method * run workflow on dev not main! * revert pre commit check branch and change post push action branch to dev * added ssh key for checkout * removed tests for faster iteration * put back publish dlls * check if latest commit isn't from github actions to avoid recursive actions * small syntax fix * small syntax fix 2 * replace conditional fix for loop issue with commit skip ci keyword in message * put tests back in * on push workflow call now back to from main * test again * reverted actor from bot to user and removed ssh setup * revert post push workflow file target back to main * chore: fix typos (ChainSafe#918) Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Metamask SDK fixes (ChainSafe#922) * Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * made main package testable, revert due to a mistake * Sign verify and WebGL login logout issue fixed for metamask --------- Co-authored-by: robGG1997 <robel@chainsafe.io> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Package built-in dependencies fix (ChainSafe#925) * Package built-in dependencies fix * Added polling and timeout to GetTransaction method Introduced DelayUtil --------- Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Ramp fix Fixed ramp via conditional compilation to avoid changing the folder structure of samples. * Amending Cleaner implementation of compilation directives * Amend Amend --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> * Sneakz/typo fix (ChainSafe#933) Update DisableGameObjectIfServiceNotActive.cs * Removing Sygma from ILoginProvider * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Auto Commit [skip ci] - Duplicate Packages Samples - Publish DLL Dependencies * Update ILoginProvider.cs --------- Co-authored-by: robGG1997 <robel@chainsafe.io> Co-authored-by: Snoppy <michaleli@foxmail.com> Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com> Co-authored-by: rob1997 <rob1997@users.noreply.github.com> Co-authored-by: kantagara <kantagara@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com> Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com> Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com> Co-authored-by: Nikola Garabandic <kantagara@gmail.com> Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing sample script comments as they were set to 1155 instead of 721. Closes #929