这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rob1997
Copy link
Collaborator

@rob1997 rob1997 commented Apr 8, 2024

closes #882 #857
run scripts/setup.sh before testing

Copy link
Contributor

@kantagara kantagara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't imported it but it looks good! Great work Rob!

Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both issues were fixed!

@rob1997 rob1997 added the ready-to-merge Ready to Merge PR - this'll trigger required checks label Apr 9, 2024
@rob1997 rob1997 added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Apr 9, 2024
@kantagara kantagara merged commit e579b89 into dev Apr 12, 2024
@kantagara kantagara deleted the rob/metamask-sdk-fixes branch April 12, 2024 07:25
sneakzttv added a commit that referenced this pull request Apr 29, 2024
* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (#922)

* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>
sneakzttv added a commit that referenced this pull request Apr 30, 2024
* Fixes to stabilize the head (#927)

* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (#922)

* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Fixing sample script comments

Fixing sample script comments as they were set to 1155 instead of 721

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>
sneakzttv added a commit that referenced this pull request Apr 30, 2024
* Fixes to stabilize the head (#927)

* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (#922)

* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Ramp fix

Fixed ramp via conditional compilation to avoid changing the folder structure of samples.

* Amending

Cleaner implementation of compilation directives

* Amend

Amend

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>
sneakzttv added a commit that referenced this pull request Apr 30, 2024
* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (#922)

* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Fixing sample script comments (#930)

* Fixes to stabilize the head (#927)

* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (#922)

* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Fixing sample script comments

Fixing sample script comments as they were set to 1155 instead of 721

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Ramp fix (#931)

* Fixes to stabilize the head (#927)

* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (#922)

* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Ramp fix

Fixed ramp via conditional compilation to avoid changing the folder structure of samples.

* Amending

Cleaner implementation of compilation directives

* Amend

Amend

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Sneakz/typo fix (#933)

Update DisableGameObjectIfServiceNotActive.cs

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
sneakzttv added a commit that referenced this pull request Apr 30, 2024
* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (#922)

* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Fixing sample script comments (#930)

* Fixes to stabilize the head (#927)

* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (#922)

* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Fixing sample script comments

Fixing sample script comments as they were set to 1155 instead of 721

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Ramp fix (#931)

* Fixes to stabilize the head (#927)

* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (#922)

* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Ramp fix

Fixed ramp via conditional compilation to avoid changing the folder structure of samples.

* Amending

Cleaner implementation of compilation directives

* Amend

Amend

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Sneakz/typo fix (#933)

Update DisableGameObjectIfServiceNotActive.cs

* Removing Sygma from ILoginProvider

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Update ILoginProvider.cs

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: Nikola Garabandic <kantagara@gmail.com>
Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
rob1997 added a commit that referenced this pull request Jan 16, 2025
* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
rob1997 added a commit that referenced this pull request Jan 16, 2025
* Fixes to stabilize the head (#927)

* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (#922)

* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Fixing sample script comments

Fixing sample script comments as they were set to 1155 instead of 721

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>
rob1997 added a commit that referenced this pull request Jan 16, 2025
* Fixes to stabilize the head (#927)

* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (#922)

* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Ramp fix

Fixed ramp via conditional compilation to avoid changing the folder structure of samples.

* Amending

Cleaner implementation of compilation directives

* Amend

Amend

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>
sergeypanin1994 pushed a commit to sergeypanin1994/web3.unity that referenced this pull request Mar 16, 2025
* Revert "automated duplicating imported samples modifications (ChainSafe#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
sergeypanin1994 pushed a commit to sergeypanin1994/web3.unity that referenced this pull request Mar 16, 2025
* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (ChainSafe#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (ChainSafe#922)

* Revert "automated duplicating imported samples modifications (ChainSafe#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (ChainSafe#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>
sergeypanin1994 pushed a commit to sergeypanin1994/web3.unity that referenced this pull request Mar 16, 2025
* Fixes to stabilize the head (ChainSafe#927)

* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (ChainSafe#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (ChainSafe#922)

* Revert "automated duplicating imported samples modifications (ChainSafe#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (ChainSafe#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Fixing sample script comments

Fixing sample script comments as they were set to 1155 instead of 721

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>
sergeypanin1994 pushed a commit to sergeypanin1994/web3.unity that referenced this pull request Mar 16, 2025
* Fixes to stabilize the head (ChainSafe#927)

* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (ChainSafe#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (ChainSafe#922)

* Revert "automated duplicating imported samples modifications (ChainSafe#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (ChainSafe#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Ramp fix

Fixed ramp via conditional compilation to avoid changing the folder structure of samples.

* Amending

Cleaner implementation of compilation directives

* Amend

Amend

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>
sergeypanin1994 pushed a commit to sergeypanin1994/web3.unity that referenced this pull request Mar 16, 2025
* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (ChainSafe#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (ChainSafe#922)

* Revert "automated duplicating imported samples modifications (ChainSafe#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (ChainSafe#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Fixing sample script comments (ChainSafe#930)

* Fixes to stabilize the head (ChainSafe#927)

* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (ChainSafe#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (ChainSafe#922)

* Revert "automated duplicating imported samples modifications (ChainSafe#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (ChainSafe#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Fixing sample script comments

Fixing sample script comments as they were set to 1155 instead of 721

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Ramp fix (ChainSafe#931)

* Fixes to stabilize the head (ChainSafe#927)

* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (ChainSafe#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (ChainSafe#922)

* Revert "automated duplicating imported samples modifications (ChainSafe#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (ChainSafe#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Ramp fix

Fixed ramp via conditional compilation to avoid changing the folder structure of samples.

* Amending

Cleaner implementation of compilation directives

* Amend

Amend

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Sneakz/typo fix (ChainSafe#933)

Update DisableGameObjectIfServiceNotActive.cs

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
sergeypanin1994 pushed a commit to sergeypanin1994/web3.unity that referenced this pull request Mar 16, 2025
* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (ChainSafe#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (ChainSafe#922)

* Revert "automated duplicating imported samples modifications (ChainSafe#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (ChainSafe#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Fixing sample script comments (ChainSafe#930)

* Fixes to stabilize the head (ChainSafe#927)

* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (ChainSafe#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (ChainSafe#922)

* Revert "automated duplicating imported samples modifications (ChainSafe#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (ChainSafe#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Fixing sample script comments

Fixing sample script comments as they were set to 1155 instead of 721

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Ramp fix (ChainSafe#931)

* Fixes to stabilize the head (ChainSafe#927)

* contribution edits

* condition to run tests fixed

* typo fix

* use deploy key for push

* bot makes push instead of actor

* fixed syntax

* setup ssh keys added

* different way for setting up ssh

* only play mode tests

* reverted ssh setup method

* run workflow on dev not main!

* revert pre commit check branch and change post push action branch to dev

* added ssh key for checkout

* removed tests for faster iteration

* put back publish dlls

* check if latest commit isn't from github actions to avoid recursive actions

* small syntax fix

* small syntax fix 2

* replace conditional fix for loop issue with commit skip ci keyword in message

* put tests back in

* on push workflow call now back to from main

* test again

* reverted actor from bot to user and removed ssh setup

* revert post push workflow file target back to main

* chore: fix typos (ChainSafe#918)

Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Metamask SDK fixes (ChainSafe#922)

* Revert "automated duplicating imported samples modifications (ChainSafe#595)"

This reverts commit a555894.

* made main package testable, revert due to a mistake

* Sign verify and WebGL login logout issue fixed for metamask

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Package built-in dependencies fix (ChainSafe#925)

* Package built-in dependencies fix

* Added polling and timeout to GetTransaction method
Introduced DelayUtil

---------

Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Ramp fix

Fixed ramp via conditional compilation to avoid changing the folder structure of samples.

* Amending

Cleaner implementation of compilation directives

* Amend

Amend

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>

* Sneakz/typo fix (ChainSafe#933)

Update DisableGameObjectIfServiceNotActive.cs

* Removing Sygma from ILoginProvider

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Auto Commit [skip ci]
- Duplicate Packages Samples
- Publish DLL Dependencies

* Update ILoginProvider.cs

---------

Co-authored-by: robGG1997 <robel@chainsafe.io>
Co-authored-by: Snoppy <michaleli@foxmail.com>
Co-authored-by: Robel Getnet Geremew <robelgetnetrg@gmail.com>
Co-authored-by: rob1997 <rob1997@users.noreply.github.com>
Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <127766834+oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: oleksandr <59798783+creeppak@users.noreply.github.com>
Co-authored-by: oleksandrchainsafe <oleksandrchainsafe@users.noreply.github.com>
Co-authored-by: Nikola Garabandic <kantagara@gmail.com>
Co-authored-by: sneakzttv <sneakzttv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to Merge PR - this'll trigger required checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SignVerify is failing to verify the transaction in Metamask login scene Login after doing a logout in Metamask not working

5 participants