Data files storage changed #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a555894.
kantagara
reviewed
Dec 12, 2023
Packages/io.chainsafe.web3-unity/Samples~/Web3.Unity/Scripts/Utilities/PlayerData.cs
Outdated
Show resolved
Hide resolved
kantagara
suggested changes
Dec 12, 2023
Contributor
kantagara
left a comment
There was a problem hiding this comment.
Need to support more platforms for opening persistant data path, not only windows.
kantagara
reviewed
Dec 12, 2023
Packages/io.chainsafe.web3-unity/Samples~/Web3.Unity/Scripts/Utilities/PlayerData.cs
Show resolved
Hide resolved
kantagara
approved these changes
Dec 12, 2023
sneakzttv
approved these changes
Dec 12, 2023
kantagara
approved these changes
Dec 13, 2023
juans-chainsafe
approved these changes
Dec 13, 2023
Contributor
juans-chainsafe
left a comment
There was a problem hiding this comment.
PlayerData.json is not anymore located in Assets folder ✅
Also, I was able to build in webgl and use the editor
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * data files now save in persistent data path only and we now have menu items in tools for easy access * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * open persistent data path supports more platforms * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
sergeypanin1994
pushed a commit
to sergeypanin1994/web3.unity
that referenced
this pull request
Mar 16, 2025
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * data files now save in persistent data path only and we now have menu items in tools for easy access * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * open persistent data path supports more platforms * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #784