-
Notifications
You must be signed in to change notification settings - Fork 243
Wallet Connect WebGL Solution #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a555894.
kantagara
reviewed
Nov 22, 2023
kantagara
approved these changes
Nov 22, 2023
Contributor
kantagara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
sneakzttv
approved these changes
Nov 22, 2023
juans-chainsafe
approved these changes
Nov 22, 2023
Contributor
juans-chainsafe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I checked every sample with WebGL and Metamask, everything is working as expected.
Just a minor issue that has a workaround:
- If I logout and then try to login again, I can't, I see the message:
[Web3] Unsupported Platform WebGLand gets stuck in[Web3] [Relayer] Waiting for connection to open - Workaround for this is to reload the page in the browser (with F5) and do it again.
RyRy79261
approved these changes
Nov 22, 2023
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * added WebGL threading patcher from - https://github.com/VolodymyrBS/WebGLThreadingPatcher.git * WebGLThreadingPatcherInstaller dialog
sergeypanin1994
pushed a commit
to sergeypanin1994/web3.unity
that referenced
this pull request
Mar 16, 2025
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * added WebGL threading patcher from - https://github.com/VolodymyrBS/WebGLThreadingPatcher.git * WebGLThreadingPatcherInstaller dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #749