-
Notifications
You must be signed in to change notification settings - Fork 243
Generate DLL .meta files #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a555894.
d0a166f to
3630b9f
Compare
cf9bdbf to
439356d
Compare
2e67fcb to
f9842c2
Compare
…ChainSafe/web3.unity into rob/generate-dll-meta-files-750
58c24de to
4778494
Compare
RyRy79261
approved these changes
Nov 22, 2023
kantagara
approved these changes
Nov 22, 2023
Contributor
kantagara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
sneakzttv
approved these changes
Nov 23, 2023
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * .meta generation CI * small ref update * possible fix * helpful echos added * now running action on this branch :facepalm * don't export DLL_META_FILE_TEMPLATE variable * small updates * back to echo * maybe try touch * helpful echos and changed overwrite to append * genrate UUID using uuidgen * if else cases for already existing meta files and only deleting .dll files * fixed path issue * rm dlls path fix * Published Solution Dependencies to Package Libraries as DLLs * changed publish dependencies action auto commit branch back to main * skip running publish dll * revert unwanted changes back to main --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
sergeypanin1994
pushed a commit
to sergeypanin1994/web3.unity
that referenced
this pull request
Mar 16, 2025
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * .meta generation CI * small ref update * possible fix * helpful echos added * now running action on this branch :facepalm * don't export DLL_META_FILE_TEMPLATE variable * small updates * back to echo * maybe try touch * helpful echos and changed overwrite to append * genrate UUID using uuidgen * if else cases for already existing meta files and only deleting .dll files * fixed path issue * rm dlls path fix * Published Solution Dependencies to Package Libraries as DLLs * changed publish dependencies action auto commit branch back to main * skip running publish dll * revert unwanted changes back to main --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #750
This will generate .meta files for DLLs if they don't already exist, Publish Dependencies action is not enabled since we'll be running the action on main which'll delete the already existing .meta files, once this is merged to main we can enable it back on!