-
Notifications
You must be signed in to change notification settings - Fork 243
IOS Redirect Wallet issue fix #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit a555894.
|
Hey yes it should be in the 2.5.4 release |
Thank you yes now after trying several times it seems it worked. I had a lot of issues with it first. In the end I updated unity to latest LTS version. and I set code stripping to false and Managed stripping level to 'minimal'. I'm not sure what made it work in the end. If you can confirm that these steps are necessary I would encourage you to put them in the documentation. Great library! Thnx |
Yes, code stripping to false and Managed stripping level to 'minimal' are necessary. Also, you may need to add the "-ld_classic" flag in XCode build settings, more information: #686 (comment) (depending on your xcode version) |
|
@dataexcess just for the testing sake, if you only updated to LTS, can you remain with the default low code stripping and set to true the engine code stripping? I would like to draw a conclusion about something. :) |
It's impossible to know this information by just following the SDK guide! Please add this to the docs to save headache for future ios developers. |
ok let me try... |
|
Ok with code stripping set to true it also works! |
|
Can you try with code stripping set to low, or even medium? @dataexcess ? |
|
When I set code stripping to low it does not work anymore. Minimal seems required! |
|
I figure medium won;t work as well ;). Sorry I have no time anymore to do testing. |
|
Thank yoiu so much for this! |
|
Is this still an issue? I am experiencing the same problem with Unity 2022.3.38. |
What SDK Version are you using? |
* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * possible redirect fix * Published Solution Dependencies to Package Libraries as DLLs * possible fix * use redirect used in WalletConnectUnity project https://github.com/WalletConnect/WalletConnectUnity/ * reverted src/UnitySampleProject/Packages/packages-lock.json to main * Published Solution Dependencies to Package Libraries as DLLs * added wc prefix to links and removed url encoding * Published Solution Dependencies to Package Libraries as DLLs * added encode to uri * Published Solution Dependencies to Package Libraries as DLLs * revert merge changes * Published Solution Dependencies to Package Libraries as DLLs * new dlls --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * possible redirect fix * Published Solution Dependencies to Package Libraries as DLLs * possible fix * use redirect used in WalletConnectUnity project https://github.com/WalletConnect/WalletConnectUnity/ * reverted src/UnitySampleProject/Packages/packages-lock.json to main * Published Solution Dependencies to Package Libraries as DLLs * added wc prefix to links and removed url encoding * Published Solution Dependencies to Package Libraries as DLLs * added encode to uri * Published Solution Dependencies to Package Libraries as DLLs * revert merge changes * Published Solution Dependencies to Package Libraries as DLLs * new dlls --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
closes #735