这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@robGG1997
Copy link
Contributor

closes #735

@robGG1997 robGG1997 self-assigned this Nov 16, 2023
@auto-assign auto-assign bot requested a review from sneakzttv November 21, 2023 06:25
@robGG1997 robGG1997 added the ready-to-merge Ready to Merge PR - this'll trigger required checks label Nov 22, 2023
@robGG1997 robGG1997 added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Nov 23, 2023
@robGG1997 robGG1997 merged commit 3cb9186 into main Nov 23, 2023
@robGG1997 robGG1997 deleted the rob/ios-redirect-wallet-fix-735 branch November 23, 2023 11:07
@kantagara
Copy link
Contributor

Hey yes it should be in the 2.5.4 release

@dataexcess
Copy link

Hey yes it should be in the 2.5.4 release

Thank you yes now after trying several times it seems it worked. I had a lot of issues with it first. In the end I updated unity to latest LTS version. and I set code stripping to false and Managed stripping level to 'minimal'. I'm not sure what made it work in the end. If you can confirm that these steps are necessary I would encourage you to put them in the documentation. Great library! Thnx

@juans-chainsafe
Copy link
Contributor

Hey yes it should be in the 2.5.4 release

Thank you yes now after trying several times it seems it worked. I had a lot of issues with it first. In the end I updated unity to latest LTS version. and I set code stripping to false and Managed stripping level to 'minimal'. I'm not sure what made it work in the end. If you can confirm that these steps are necessary I would encourage you to put them in the documentation. Great library! Thnx

Yes, code stripping to false and Managed stripping level to 'minimal' are necessary. Also, you may need to add the "-ld_classic" flag in XCode build settings, more information: #686 (comment) (depending on your xcode version)

@kantagara
Copy link
Contributor

kantagara commented Dec 4, 2023

@dataexcess just for the testing sake, if you only updated to LTS, can you remain with the default low code stripping and set to true the engine code stripping? I would like to draw a conclusion about something. :)

@dataexcess
Copy link

Hey yes it should be in the 2.5.4 release

Thank you yes now after trying several times it seems it worked. I had a lot of issues with it first. In the end I updated unity to latest LTS version. and I set code stripping to false and Managed stripping level to 'minimal'. I'm not sure what made it work in the end. If you can confirm that these steps are necessary I would encourage you to put them in the documentation. Great library! Thnx

Yes, code stripping to false and Managed stripping level to 'minimal' are necessary. Also, you may need to add the "-ld_classic" flag in XCode build settings, more information: #686 (comment) (depending on your xcode version)

It's impossible to know this information by just following the SDK guide! Please add this to the docs to save headache for future ios developers.

@dataexcess
Copy link

@dataexcess just for the testing sake, if you only updated to LTS, can you remain with the default low code stripping and set to true the engine code stripping? I would like to draw a conclusion about something. :)

ok let me try...

@dataexcess
Copy link

Ok with code stripping set to true it also works!

@kantagara
Copy link
Contributor

Can you try with code stripping set to low, or even medium? @dataexcess ?

@dataexcess
Copy link

When I set code stripping to low it does not work anymore. Minimal seems required!

@dataexcess
Copy link

I figure medium won;t work as well ;). Sorry I have no time anymore to do testing.

@kantagara
Copy link
Contributor

Thank yoiu so much for this!

@wagenheimer
Copy link

Is this still an issue? I am experiencing the same problem with Unity 2022.3.38.

@kantagara
Copy link
Contributor

Is this still an issue? I am experiencing the same problem with Unity 2022.3.38.

What SDK Version are you using?

rob1997 pushed a commit that referenced this pull request Jan 16, 2025
* Revert "automated duplicating imported samples modifications (#595)"

This reverts commit a555894.

* possible redirect fix

* Published Solution Dependencies to Package Libraries as DLLs

* possible fix

* use redirect used in WalletConnectUnity project https://github.com/WalletConnect/WalletConnectUnity/

* reverted src/UnitySampleProject/Packages/packages-lock.json to main

* Published Solution Dependencies to Package Libraries as DLLs

* added wc prefix to links and removed url encoding

* Published Solution Dependencies to Package Libraries as DLLs

* added encode to uri

* Published Solution Dependencies to Package Libraries as DLLs

* revert merge changes

* Published Solution Dependencies to Package Libraries as DLLs

* new dlls

---------

Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
sergeypanin1994 pushed a commit to sergeypanin1994/web3.unity that referenced this pull request Mar 16, 2025
* Revert "automated duplicating imported samples modifications (ChainSafe#595)"

This reverts commit a555894.

* possible redirect fix

* Published Solution Dependencies to Package Libraries as DLLs

* possible fix

* use redirect used in WalletConnectUnity project https://github.com/WalletConnect/WalletConnectUnity/

* reverted src/UnitySampleProject/Packages/packages-lock.json to main

* Published Solution Dependencies to Package Libraries as DLLs

* added wc prefix to links and removed url encoding

* Published Solution Dependencies to Package Libraries as DLLs

* added encode to uri

* Published Solution Dependencies to Package Libraries as DLLs

* revert merge changes

* Published Solution Dependencies to Package Libraries as DLLs

* new dlls

---------

Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to Merge PR - this'll trigger required checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redirect to wallet doesn't prompt the connection in iOS

8 participants