Meta Mask Integration #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a555894.
5a3ab85 to
35498eb
Compare
oleksandrchainsafe
approved these changes
Dec 11, 2023
kantagara
approved these changes
Dec 11, 2023
Contributor
|
checking again with new changes, one moment. |
Contributor
|
Good to go!
|
sneakzttv
approved these changes
Dec 11, 2023
robGG1997
added a commit
that referenced
this pull request
Dec 11, 2023
* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * added WebGL threading patcher from - https://github.com/VolodymyrBS/WebGLThreadingPatcher.git * working demo and build * Revert "working demo and build" This reverts commit 06cb9d9. * first MetaMask iteration * Auto-duplicate Packages Samples * added new custom dlls for Neth.MetaMask * typo and compile error fixes * Published Solution Dependencies to Package Libraries as DLLs * sign message and sign typed data implemented and working, send transaction implemented not fully working * fixed send Transaction issue * simultaneous requests supported and fixed send transaction issue * refactor and documentation * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * set exception if connection fails * added required line in index.html in WebGL template * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * libc Dll not found exception fixed * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * made requested changes * Published Solution Dependencies to Package Libraries as DLLs * more requested changes * merged wallet connect extension methods * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * removed redundant/empty implementations of IlifeCycleParticipant * added import statement * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * added platform dependent compilation to avoid build errors * limited metamask libs to WebGL so it can build to other platforms * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * revert from merge * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * added WebGL threading patcher from - https://github.com/VolodymyrBS/WebGLThreadingPatcher.git * working demo and build * Revert "working demo and build" This reverts commit 06cb9d9. * first MetaMask iteration * Auto-duplicate Packages Samples * added new custom dlls for Neth.MetaMask * typo and compile error fixes * Published Solution Dependencies to Package Libraries as DLLs * sign message and sign typed data implemented and working, send transaction implemented not fully working * fixed send Transaction issue * simultaneous requests supported and fixed send transaction issue * refactor and documentation * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * set exception if connection fails * added required line in index.html in WebGL template * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * made requested changes * Published Solution Dependencies to Package Libraries as DLLs * more requested changes * merged wallet connect extension methods * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * removed redundant/empty implementations of IlifeCycleParticipant * added import statement * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * added platform dependent compilation to avoid build errors * limited metamask libs to WebGL so it can build to other platforms * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Revert "automated duplicating imported samples modifications (#595)" This reverts commit a555894. * added WebGL threading patcher from - https://github.com/VolodymyrBS/WebGLThreadingPatcher.git * working demo and build * Revert "working demo and build" This reverts commit 06cb9d9. * first MetaMask iteration * Auto-duplicate Packages Samples * added new custom dlls for Neth.MetaMask * typo and compile error fixes * Published Solution Dependencies to Package Libraries as DLLs * sign message and sign typed data implemented and working, send transaction implemented not fully working * fixed send Transaction issue * simultaneous requests supported and fixed send transaction issue * refactor and documentation * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * set exception if connection fails * added required line in index.html in WebGL template * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * libc Dll not found exception fixed * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * made requested changes * Published Solution Dependencies to Package Libraries as DLLs * more requested changes * merged wallet connect extension methods * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * removed redundant/empty implementations of IlifeCycleParticipant * added import statement * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * added platform dependent compilation to avoid build errors * limited metamask libs to WebGL so it can build to other platforms * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * revert from merge * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
sergeypanin1994
pushed a commit
to sergeypanin1994/web3.unity
that referenced
this pull request
Mar 16, 2025
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * added WebGL threading patcher from - https://github.com/VolodymyrBS/WebGLThreadingPatcher.git * working demo and build * Revert "working demo and build" This reverts commit 06cb9d9. * first MetaMask iteration * Auto-duplicate Packages Samples * added new custom dlls for Neth.MetaMask * typo and compile error fixes * Published Solution Dependencies to Package Libraries as DLLs * sign message and sign typed data implemented and working, send transaction implemented not fully working * fixed send Transaction issue * simultaneous requests supported and fixed send transaction issue * refactor and documentation * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * set exception if connection fails * added required line in index.html in WebGL template * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * made requested changes * Published Solution Dependencies to Package Libraries as DLLs * more requested changes * merged wallet connect extension methods * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * removed redundant/empty implementations of IlifeCycleParticipant * added import statement * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * added platform dependent compilation to avoid build errors * limited metamask libs to WebGL so it can build to other platforms * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
sergeypanin1994
pushed a commit
to sergeypanin1994/web3.unity
that referenced
this pull request
Mar 16, 2025
* Revert "automated duplicating imported samples modifications (ChainSafe#595)" This reverts commit a555894. * added WebGL threading patcher from - https://github.com/VolodymyrBS/WebGLThreadingPatcher.git * working demo and build * Revert "working demo and build" This reverts commit 06cb9d9. * first MetaMask iteration * Auto-duplicate Packages Samples * added new custom dlls for Neth.MetaMask * typo and compile error fixes * Published Solution Dependencies to Package Libraries as DLLs * sign message and sign typed data implemented and working, send transaction implemented not fully working * fixed send Transaction issue * simultaneous requests supported and fixed send transaction issue * refactor and documentation * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * set exception if connection fails * added required line in index.html in WebGL template * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * libc Dll not found exception fixed * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * made requested changes * Published Solution Dependencies to Package Libraries as DLLs * more requested changes * merged wallet connect extension methods * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * removed redundant/empty implementations of IlifeCycleParticipant * added import statement * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * added platform dependent compilation to avoid build errors * limited metamask libs to WebGL so it can build to other platforms * Auto-duplicate Packages Samples * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * Published Solution Dependencies to Package Libraries as DLLs * revert from merge * Published Solution Dependencies to Package Libraries as DLLs --------- Co-authored-by: robGG1997 <robGG1997@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #517
Note : this only works on WebGL build (not in editor)
Before Building to WebGL
To run add
SampleLogin - MetaMaskscene to build settings at index of 0 andSampleMainat index 1Reimport WebGL templates
OR
Once Build has finished go into the build directory and edit the
index.htmfile to include this line right hereBuild And Runto WebGL or just Build then you can then run the WebGL build from CMD using"C:/Program Files/Unity/Hub/Editor/2021.3.22f1/Editor/Data/MonoBleedingEdge/bin/mono.exe" "C:/Program Files/Unity/Hub/Editor/2021.3.22f1/Editor/Data/PlaybackEngines/WebGLSupport/BuildTools/SimpleWebServer.exe" "[Build Directory]" 60606- DO make sure that paths are correct and replace[Build Directory]with your own build directoryNow open http://localhost:60606/ on your browser (preferably chromium based like chrome/brave)
Once this PR is approved and ready to merge I'll add the new dependency DLLs to be copied in publish dependencies CI so they can be automatically generated.