-
Notifications
You must be signed in to change notification settings - Fork 243
Embedded Wallet PR - 1 #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded Wallet PR - 1 #1272
Conversation
juans-chainsafe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the following build error after run setup.sh:
/Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Runtime/Scripts/Reown/NativeWebSocketConnectionBuilder.cs(13,68): error CS0535: 'NativeWebSocketConnectionBuilder' does not implement interface member 'IConnectionBuilder.CreateConnection(string, string)'
Running |
250d282 to
a202d79
Compare
a202d79 to
a04bf39
Compare
6501431 to
ae69f12
Compare
18e7c5b to
4d92998
Compare
4d92998 to
0402b8e
Compare
0402b8e to
2df3680
Compare
juans-chainsafe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good in the editor, but I got this error when trying to build on WebGL:
IndexOutOfRangeException: Index was outside the bounds of the array.
UnityEditor.WebGL.WebGlBuildPostprocessor.PostProcess (UnityEditor.Modules.BuildPostProcessArgs args) (at <bc61694a430045aa840dd5427917ecbb>:0)
UnityEditor.Modules.DefaultBuildPostprocessor.PostProcess (UnityEditor.Modules.BuildPostProcessArgs args, UnityEditor.BuildProperties& outProperties) (at /Users/bokken/build/output/unity/unity/Editor/Mono/Modules/DefaultBuildPostprocessor.cs:30)
UnityEditor.PostprocessBuildPlayer.Postprocess (UnityEditor.BuildTargetGroup targetGroup, UnityEditor.BuildTarget target, System.Int32 subtarget, System.String installPath, System.String companyName, System.String productName, System.Int32 width, System.Int32 height, UnityEditor.BuildOptions options, UnityEditor.RuntimeClassRegistry usedClassRegistry, UnityEditor.Build.Reporting.BuildReport report) (at /Users/bokken/build/output/unity/unity/Editor/Mono/BuildPipeline/PostprocessBuildPlayer.cs:370)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&) (at /Users/bokken/build/output/unity/unity/Modules/IMGUI/GUIUtility.cs:203)
Build completed with a result of 'Failed' in 21 seconds (20899 ms)
IndexOutOfRangeException: Index was outside the bounds of the array.
UnityEngine.GUIUtility:ProcessEvent (int,intptr,bool&) (at /Users/bokken/build/output/unity/unity/Modules/IMGUI/GUIUtility.cs:203)
|
@juans-chainsafe just open player settings and select proper webgl template |
yes, that one is selected by default, but now Im not getting the error. Not sure what changed, restarting Unity? or bring dev changes to this branch. Or when I first open Player settings, our template is selected |
We have that under FAQ. Rob also couldn't figure the issue, but the root cause is that it couldn't find the template even tho the template IS there, so it's on Unity |
juans-chainsafe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Web3Auth working as expected in editor and WebGL. Samples are also working.
Embedded Wallet implemented as a Project
EmbeddedWalletTransactionExecutorimplemented, used inWeb3AuthEmbedded Wallet UI implemented (just UI for now)
Old Web3Auth Wallet GUI refactored for this new implementation