这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@rob1997
Copy link
Collaborator

@rob1997 rob1997 commented Oct 23, 2024

Extra commits don't hide required checks anymore

Won't work unless merged but here are successful runs/triggers
https://github.com/ChainSafe/web3.unity/actions/runs/11480281781
https://github.com/ChainSafe/web3.unity/actions/runs/11480300159
We also can't update required checks on branch protection rules till these actions are on main
Sync Branches also fixed

@rob1997 rob1997 self-assigned this Oct 23, 2024
@rob1997 rob1997 added the sync label Oct 23, 2024
@rob1997 rob1997 added sync and removed sync labels Oct 23, 2024
@github-actions github-actions bot added the ready-to-merge Ready to Merge PR - this'll trigger required checks label Oct 23, 2024
@rob1997 rob1997 removed ready-to-merge Ready to Merge PR - this'll trigger required checks sync labels Oct 23, 2024
@rob1997 rob1997 marked this pull request as ready for review October 23, 2024 10:33
@rob1997 rob1997 changed the title New-ish CI Flow New-ish CI Flow [Don't Review] Ready for Review for testing Oct 23, 2024
@rob1997 rob1997 added the sync label Oct 23, 2024
@github-actions github-actions bot added the ready-to-merge Ready to Merge PR - this'll trigger required checks label Oct 23, 2024
@kantagara kantagara added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Oct 23, 2024
@rob1997 rob1997 added sync and removed ready-to-merge Ready to Merge PR - this'll trigger required checks sync labels Oct 23, 2024
@github-actions github-actions bot added the ready-to-merge Ready to Merge PR - this'll trigger required checks label Oct 23, 2024
@rob1997 rob1997 removed the ready-to-merge Ready to Merge PR - this'll trigger required checks label Oct 23, 2024
@rob1997 rob1997 added sync and removed sync labels Oct 23, 2024
@rob1997 rob1997 added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed sync labels Oct 23, 2024
@rob1997 rob1997 added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Oct 23, 2024
@rob1997 rob1997 changed the title New-ish CI Flow [Don't Review] Ready for Review for testing CI Flow Fix Oct 23, 2024
@rob1997 rob1997 merged commit 5ba20ca into main Oct 23, 2024
8 checks passed
@rob1997 rob1997 deleted the rob/ci-fix-1 branch October 23, 2024 15:42
rob1997 added a commit that referenced this pull request Jan 16, 2025
* label PR at the end of extra commits

* workflow ref changed for testing

* trigger condition fixed

* try labeler with GitHub token

* maybe with deploy key

* check on sync triggers

* push trigger working now cleaned up for PR

* checks only trigger if PR is ready for review or if it's labeled ready-to-merge

* env reference fixed

* pre job needs check_commit

* added name for pre job
sergeypanin1994 pushed a commit to sergeypanin1994/web3.unity that referenced this pull request Mar 16, 2025
* label PR at the end of extra commits

* workflow ref changed for testing

* trigger condition fixed

* try labeler with GitHub token

* maybe with deploy key

* check on sync triggers

* push trigger working now cleaned up for PR

* checks only trigger if PR is ready for review or if it's labeled ready-to-merge

* env reference fixed

* pre job needs check_commit

* added name for pre job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to Merge PR - this'll trigger required checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants