这是indexloc提供的服务，不要输入任何密码
Skip to content

Connect on Initialize Fix #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Connect on Initialize Fix #1158

wants to merge 5 commits into from

Conversation

@rob1997
Copy link
Collaborator

@rob1997 rob1997 commented Sep 20, 2024 •
edited
Loading

There were issues in async execution order for web3auth in async plus some unhandled errors/exceptions

Bug was that connect would get stuck while trying to restore web3auth session

@rob1997 rob1997 self-assigned this Sep 20, 2024
sneakzttv
sneakzttv approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@sneakzttv sneakzttv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun unity specific way to pause for a frame, please add a description to the issue though. It looks messy without it.

image

@sneakzttv sneakzttv added the ready-to-merge Ready to Merge PR - this'll trigger required checks label Sep 22, 2024
@rob1997
Copy link
Collaborator Author

rob1997 commented Sep 23, 2024

Fun unity specific way to pause for a frame, please add a description to the issue though. It looks messy without it.

image

good call, I've updated the description of the PR

@rob1997 rob1997 added ready-to-merge Ready to Merge PR - this'll trigger required checks and removed ready-to-merge Ready to Merge PR - this'll trigger required checks labels Sep 23, 2024
@rob1997
Copy link
Collaborator Author

rob1997 commented Sep 23, 2024

Emm this was merged as part of #1154

@rob1997 rob1997 closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@creeppak creeppak Awaiting requested review from creeppak

3 more reviewers

@kantagara kantagara kantagara approved these changes

@sneakzttv sneakzttv sneakzttv approved these changes

@juans-chainsafe juans-chainsafe juans-chainsafe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rob1997 rob1997

Labels

ready-to-merge Ready to Merge PR - this'll trigger required checks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rob1997 @kantagara @sneakzttv @juans-chainsafe