这是indexloc提供的服务，不要输入任何密码
Skip to content

Bugfix. Integration tests were using an empty project config. #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Bugfix. Integration tests were using an empty project config. #1122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18d552b
Added another assert statement to throw a different message when ther…
creeppak Sep 3, 2024
4a60d04
Slightly updated the exception message format.
creeppak Sep 3, 2024
51d65ff
Made Integration tests always use hardcoded Project Config
creeppak Sep 3, 2024
c3cca39
Merge branch 'dev' into oleksandr/integration-tests-bug-project-config
kantagara Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions Packages/io.chainsafe.web3-unity/Tests/Runtime/SampleTestsBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,10 @@ public virtual IEnumerator TearDown()

internal static ValueTask<Web3> BuildTestWeb3(Web3Builder.ConfigureServicesDelegate customConfiguration = null)
{
// Set project config, fallback is for github as it doesn't load
var projectConfigScriptableObject = ProjectConfigUtilities.Load();
if (projectConfigScriptableObject == null)
{
projectConfigScriptableObject = ProjectConfigUtilities.Create("3dc3e125-71c4-4511-a367-e981a6a94371", "11155111",
"Ethereum", "Sepolia", "Seth", "https://sepolia.infura.io/v3/287318045c6e455ab34b81d6bcd7a65f", "https://sepolia.etherscan.io/", false, "wss://sepolia.drpc.org");
}
var projectConfigScriptableObject = ProjectConfigUtilities.Create("3dc3e125-71c4-4511-a367-e981a6a94371",
"11155111",
"Ethereum", "Sepolia", "Seth", "https://sepolia.infura.io/v3/287318045c6e455ab34b81d6bcd7a65f",
"https://sepolia.etherscan.io/", false, "wss://sepolia.drpc.org");

// Create web3builder & assign services
var web3Builder = new Web3Builder(projectConfigScriptableObject).Configure(services =>
Expand Down
17 changes: 13 additions & 4 deletions src/ChainSafe.Gaming.Unity/UnityHttpClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,20 @@ public UnityHttpClient(IMainThreadRunner mainThreadRunner)
/// <returns>Converted Network Response.</returns>
private static NetworkResponse<string> UnityWebRequestToNetworkResponse(UnityWebRequest request)
{
Assert.AreNotEqual(request.result, UnityWebRequest.Result.InProgress);

if (request.result != UnityWebRequest.Result.Success)
// Assert response is successful
{
throw new Web3Exception($"HTTP.{request.method} to {request.url} responded with error: {request.downloadHandler.text}");
Assert.AreNotEqual(UnityWebRequest.Result.InProgress, request.result);

if (request.result == UnityWebRequest.Result.ConnectionError)
{
throw new Web3Exception($"HTTP.{request.method} to '{request.url}' - connection error.");
}

if (request.result != UnityWebRequest.Result.Success)
{
throw new Web3Exception(
$"HTTP.{request.method} to '{request.url}' responded with error: {request.downloadHandler.text}");
}
}

return NetworkResponse<string>.Success(request.downloadHandler.text);
Expand Down