Marketplace prefab #1048
Closed
Marketplace prefab #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browsing bugs fixed
juans-chainsafe
suggested changes
Jul 2, 2024
Contributor
juans-chainsafe
left a comment
There was a problem hiding this comment.
I added a Event System into a new scene and the MarketplaceLogin.prefab to test.
But I get different errors.
- After login:
NullReferenceException: Object reference not set to an instance of an object
Scripts.EVM.Remote.CSServer.GetDataWithToken[T] (System.String _path, System.String _bearerToken, System.Int32 offset, System.Int32 pageSize) (at /Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity/Runtime/Scripts/EVM/Remote/CSServer.cs:49)
Scripts.EVM.Marketplace.Marketplace.GetProjectMarketplaces (System.String bearerToken) (at /Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity.marketplace/Runtime/Scripts/Marketplace/Marketplace.cs:31)
ChainSafe.Gaming.Marketplace.BrowseMarketplaceManager.GetProjectMarketplaces () (at Assets/Samples/web3.unity SDK Marketplace/2.6.1/Marketplace Samples/Scripts/BrowseMarketplaceManager.cs:63)
System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.<ThrowAsync>b__7_0 (System.Object state) (at <e307bbb467104258887a104f6151f183>:0)
UnityEngine.UnitySynchronizationContext+WorkRequest.Invoke () (at /Users/bokken/build/output/unity/unity/Runtime/Export/Scripting/UnitySynchronizationContext.cs:153)
UnityEngine.UnitySynchronizationContext.Exec () (at /Users/bokken/build/output/unity/unity/Runtime/Export/Scripting/UnitySynchronizationContext.cs:83)
UnityEngine.UnitySynchronizationContext.ExecuteTasks () (at /Users/bokken/build/output/unity/unity/Runtime/Export/Scripting/UnitySynchronizationContext.cs:107)
- Trying to create a Marketplace
NullReferenceException: Object reference not set to an instance of an object
Scripts.EVM.Marketplace.Marketplace.CreateMarketplace (System.String _bearerToken, System.String _name, System.String _description, System.Boolean _whitelisting) (at /Users/juanmanuelspoleti/Desktop/workspace/web3.unity/Packages/io.chainsafe.web3-unity.marketplace/Runtime/Scripts/Marketplace/Marketplace.cs:334)
ChainSafe.Gaming.Marketplace.CreateMarketplaceManager.CreateMarketplace (System.String marketplaceName, System.String marketplaceDescription, System.Boolean marketplaceWhiteListing) (at Assets/Samples/web3.unity SDK Marketplace/2.6.1/Marketplace Samples/Scripts/CreateMarketplaceManager.cs:41)
System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.<ThrowAsync>b__7_0 (System.Object state) (at <e307bbb467104258887a104f6151f183>:0)
UnityEngine.UnitySynchronizationContext+WorkRequest.Invoke () (at /Users/bokken/build/output/unity/unity/Runtime/Export/Scripting/UnitySynchronizationContext.cs:153)
UnityEngine.UnitySynchronizationContext.Exec () (at /Users/bokken/build/output/unity/unity/Runtime/Export/Scripting/UnitySynchronizationContext.cs:83)
UnityEngine.UnitySynchronizationContext.ExecuteTasks () (at /Users/bokken/build/output/unity/unity/Runtime/Export/Scripting/UnitySynchronizationContext.cs:107)
-
Also, description for Marketplace should be optional, is not mandatory to add a description
-
Create a collection asks me for 4 images, but it should be only 2
Contributor
Author
|
Login token error is web3auth wallet related, needs a null check, will fix in another PR as it's out of scope. Marketplace description & name has been made optional. Image uploads should be at 2 images now instead of 4. |
processing bool was missing a reset after execution.
oleksandrchainsafe
suggested changes
Jul 9, 2024
| public string cursor { get; set; } | ||
| public List<Item> items { get; set; } | ||
| public List<Owners> owners { get; set; } | ||
| #region ProjectMarketplaces |
Contributor
There was a problem hiding this comment.
This should be moved to Samples too (if you still need it), otherwise, we are going to have two implementations of the same thing in the package.
Contributor
There was a problem hiding this comment.
Just to be clear, I'm talking about the whole implementation, not just this file.
Contributor
Author
There was a problem hiding this comment.
will clean it up in next PR, too many changes in this one.
| namespace ChainSafe.Gaming.Marketplace | ||
| // <copyright file="MarketplaceItemStatus.cs" company="PlaceholderCompany"> | ||
| // Copyright (c) PlaceholderCompany. All rights reserved. | ||
| // </copyright> |
Contributor
There was a problem hiding this comment.
Remove this placeholder header pls and update from dev. After you update, lint.bat will no longer generate this bs in the files of Marketplace project.
| MarketplaceItemStatus? filterStatus = null, | ||
| MarketplaceSortType sortType = MarketplaceSortType.None, | ||
| MarketplaceSortOrder? sortOrder = null) | ||
| public Task<MarketplacePage> LoadPage(MarketplacePage? prevPage = null) |
Contributor
There was a problem hiding this comment.
This looks like it overwrites the recent marketplace update. Please make sure this doesn't get written to dev.
This reverts commit d65d9ac.
resetting marketplace scripts
Contributor
Author
|
conflicts are messy, need to fix |
Contributor
Author
|
closing for #1057 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MarketplacePrefab.mp4
To Test:
Drop the prefab from marketplace samples into a scene with an event manager, click around, have fun, woot woot.
I want to swap the calls to use the marketplace client calls but it will require some refactoring. I'd prefer to test basic functionality first and then optimize and cleanup in the next PR to keep it granular.