这是indexloc提供的服务，不要输入任何密码
Skip to content

chore: include block slot in proposal signature errors #8603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2025
Merged

chore: include block slot in proposal signature errors #8603

merged 1 commit into from
Nov 4, 2025
+2 −1

Conversation

@nflaig
Copy link
Member

@nflaig nflaig commented Nov 4, 2025

Would be great to know for which slot this block was

@nflaig nflaig requested a review from a team as a code owner November 4, 2025 13:39
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 4, 2025

Summary of Changes

Hello @nflaig, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the diagnostic capabilities of the system by adding the blockSlot to PROPOSAL_SIGNATURE_INVALID errors. This change provides crucial information about the specific slot for which a block's signature was deemed invalid, making it easier to debug and understand the context of such errors.

Highlights

  • Enhanced Error Reporting: The PROPOSAL_SIGNATURE_INVALID error type now includes the blockSlot to provide more context when a block's proposal signature is found to be invalid.
  • Error Propagation: The validateGossipBlock function has been updated to correctly pass the blockSlot when throwing a PROPOSAL_SIGNATURE_INVALID error, ensuring the new error detail is utilized.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances error reporting for invalid proposal signatures by including the block slot in the error details. The changes in blockError.ts and block.ts are correct and consistent. I've added one comment regarding improving test coverage for this change to ensure its correctness is verified automatically.

@codecov
Copy link

codecov bot commented Nov 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.96%. Comparing base (f3703b7) to head (aaadc71).
⚠️ Report is 1 commits behind head on unstable.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #8603      +/-   ##
============================================
- Coverage     51.96%   51.96%   -0.01%     
============================================
  Files           848      848              
  Lines         65928    65929       +1     
  Branches       4813     4814       +1     
============================================
- Hits          34261    34259       -2     
- Misses        31599    31602       +3     
  Partials         68       68
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

matthewkeil
matthewkeil approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewkeil matthewkeil merged commit 68f0ed9 into unstable Nov 4, 2025
24 of 27 checks passed
@matthewkeil matthewkeil deleted the nflaig/blockslot branch November 4, 2025 14:19
@philknows philknows mentioned this pull request Nov 4, 2025
Merged
@wemeetagain
Copy link
Member

wemeetagain commented Nov 4, 2025

🎉 This PR is included in v1.36.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewkeil matthewkeil matthewkeil approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nflaig @wemeetagain @matthewkeil