-
-
Notifications
You must be signed in to change notification settings - Fork 414
feat: schedule fulu and BPOs on mainnet #8590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nflaig
commented
Oct 30, 2025
- Set fork epoch & blob schedule for Fulu ethereum/consensus-specs#4689
Summary of ChangesHello @nflaig, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces critical updates to the mainnet configuration by precisely scheduling the Fulu fork and defining specific parameters for future blob processing. These changes are foundational for the planned evolution of the network, ensuring the timely activation of protocol upgrades and optimizing data handling capabilities for enhanced scalability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request schedules the Fulu fork and introduces a schedule for increasing the maximum blobs per block on mainnet, aligning with the linked consensus-specs proposal. The changes look good, but I found a minor inconsistency in a comment, which I've detailed below.
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8590 +/- ##
============================================
+ Coverage 51.91% 51.92% +0.01%
============================================
Files 848 848
Lines 65797 65806 +9
Branches 4797 4800 +3
============================================
+ Hits 34156 34171 +15
+ Misses 31572 31566 -6
Partials 69 69 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in v1.36.0 🎉 |