chore: fix type checks in merkle proof test #8550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary of ChangesHello @nflaig, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on resolving an issue where type checks in the Merkle proof test suite were failing. The changes involve refining the conditional logic and type assertions used when processing Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a type-checking issue in the merkle proof tests by correctly narrowing types for different forks. While this resolves the compile-time error, the logic for handling forks is fragile and could lead to runtime errors if test configurations change. I've provided a suggestion to refactor the logic to be more robust and readable by explicitly handling each fork generation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8550 +/- ##
============================================
- Coverage 52.18% 52.18% -0.01%
============================================
Files 852 852
Lines 65299 65317 +18
Branches 4793 4792 -1
============================================
+ Hits 34079 34086 +7
- Misses 31151 31162 +11
Partials 69 69 🚀 New features to boost your workflow:
|
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
The pull request fixes type checks in the merkle proof test by adding support for ForkPreGloas and updating the logic for determining the leaf node. The changes include new imports, conditional logic for handling different forks, and a temporary error for the ForkPostGloas case.
wemeetagain
approved these changes
Oct 20, 2025
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses broken type checks in the merkle proof tests. The changes introduce a necessary guard to skip tests for the gloas fork and beyond, where blobKzgCommitments is removed from BeaconBlockBody. The type assertions for the body object have also been refined with more specific fork types, which correctly resolves the type errors. The changes are accurate and effectively fix the issue.
Contributor
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
Member
|
🎉 This PR is included in v1.36.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type checks are broken since we merged #8469.