-
-
Notifications
You must be signed in to change notification settings - Fork 414
chore: unhide prune history option #8547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @nflaig, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request re-enables and documents the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request unhides the --chain.pruneHistory option, making it visible in the CLI and documentation. The changes are straightforward and achieve the intended goal. I've added one suggestion to improve the documentation by including a caveat about the initial performance of this feature, as mentioned in the PR description. This will help manage user expectations.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully unhides the --chain.pruneHistory option, making it officially supported. The accompanying documentation update is clear and helpfully includes a warning about the initial pruning time on large databases. The adjustment to the histogram buckets for lodestar_prune_history_fetch_keys_time_seconds is a good improvement for metrics granularity. I've added one suggestion to also update the buckets for the pruneKeys metric for consistency, as it appears to have a similar performance profile.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8547 +/- ##
============================================
- Coverage 52.18% 52.18% -0.01%
============================================
Files 852 852
Lines 65299 65298 -1
Branches 4790 4792 +2
============================================
- Hits 34079 34078 -1
Misses 31151 31151
Partials 69 69 🚀 New features to boost your workflow:
|
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
|
🎉 This PR is included in v1.36.0 🎉 |
Reverts #7448 to unhide prune history option. I've been running this on mainnet for a while and it's seems pretty stable with no noticable impact on performance. The feature is already widely used even though it was hidden so might as well show it in our docs.
Metrics from my node
I did a few tweaks to how we query keys but nothing really improved the fetch keys duration.
Caveat still remains that it's quite slow on first startup if the previous db is large but that's a one time operation.
Closes #7556