feat: add gloas containers #8464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8464 +/- ##
============================================
+ Coverage 52.22% 52.25% +0.03%
============================================
Files 853 852 -1
Lines 64899 64973 +74
Branches 4767 4769 +2
============================================
+ Hits 33894 33954 +60
- Misses 30935 30950 +15
+ Partials 70 69 -1 🚀 New features to boost your workflow:
|
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
reviewed
Sep 25, 2025
| currentSyncCommittee: altairSsz.SyncCommittee, | ||
| nextSyncCommittee: altairSsz.SyncCommittee, | ||
| // Execution | ||
| // latestExecutionPayloadHeader: ExecutionPayloadHeader, // Removed in GLOAS:EIP7732 |
Member
There was a problem hiding this comment.
this was removed but ExecutionPayloadBid was added, we should make sure we are update to date with v1.6.0-beta.0 which is the spec that will be used for devnet-0
should look into how we can activate ssz static tests already
Contributor
Author
There was a problem hiding this comment.
should look into how we can activate ssz static tests already
Probably non-trivial to do because SkipOpts.skippedForks is applied to all spec tests. Can't run ssz static tests only for gloas.
But I can run it locally and see the result
nflaig
reviewed
Sep 25, 2025
| const stateGloas = state as CompositeViewDU<typeof ssz.gloas.BeaconState>; | ||
| stateGloas.fork.previousVersion = config.GLOAS_FORK_VERSION; | ||
| stateGloas.fork.currentVersion = config.GLOAS_FORK_VERSION; | ||
| stateGloas.latestExecutionPayloadHeader = |
Member
There was a problem hiding this comment.
might need to initialize latest_execution_payload_bid here
Contributor
Author
There was a problem hiding this comment.
might need to initialize
latest_execution_payload_bidhere
Why do we need to do it?
Member
There was a problem hiding this comment.
for same reason we need a default value for latestExecutionPayloadHeader, it's gonna need some value in the genesis state
Member
There was a problem hiding this comment.
can keep this out for now, we are not starting genesis from gloas for now anyways in our tests
Member
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the SSZ container definitions for the new gloas fork, including new types for the beacon block body, beacon state, and various attestation-related structures. The changes are mostly additive, preparing the codebase for the upcoming fork. The integration of these new types is partially deferred, as indicated by TODO comments, which aligns with the PR description. My review found a minor but important typo in one of the new BeaconState fields, for which I've suggested a fix.
ensi321
commented
Sep 26, 2025
| BeaconBlockBody: electra.BeaconBlockBody; | ||
| BeaconState: gloas.BeaconState; | ||
| SignedBeaconBlock: gloas.SignedBeaconBlock; | ||
| BeaconBlock: electra.BeaconBlock; // TODO GLOAS: Use Gloas type |
Contributor
Author
There was a problem hiding this comment.
This is temporarily set to electra because there is a lot of type issue that needs to be fixed with the latest definition of gloas.BeaconBlock and others
| currentSyncCommittee: altairSsz.SyncCommittee, | ||
| nextSyncCommittee: altairSsz.SyncCommittee, | ||
| // Execution | ||
| // latestExecutionPayloadHeader: ExecutionPayloadHeader, // Removed in GLOAS:EIP7732 |
Contributor
Author
There was a problem hiding this comment.
should look into how we can activate ssz static tests already
Probably non-trivial to do because SkipOpts.skippedForks is applied to all spec tests. Can't run ssz static tests only for gloas.
But I can run it locally and see the result
Member
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the SSZ container types for the upcoming gloas fork, which includes significant changes related to proposer-builder separation. The changes are well-contained and primarily involve adding new type definitions in packages/types/src/gloas/. The PR also updates test configurations to accommodate the new spec version. The approach of adding TODO markers for full integration in a future PR is reasonable for incremental development. My review focuses on improving the maintainability of the new SSZ type definitions by reducing code duplication and making them more declarative.
nflaig
approved these changes
Sep 26, 2025
| const stateGloas = state as CompositeViewDU<typeof ssz.gloas.BeaconState>; | ||
| stateGloas.fork.previousVersion = config.GLOAS_FORK_VERSION; | ||
| stateGloas.fork.currentVersion = config.GLOAS_FORK_VERSION; | ||
| stateGloas.latestExecutionPayloadHeader = |
Member
There was a problem hiding this comment.
can keep this out for now, we are not starting genesis from gloas for now anyways in our tests
nflaig
added a commit
that referenced
this pull request
Oct 2, 2025
Update gloas types in `packages/types/src/types.ts` to use the containers defined in #8464 and fix all type error that come along with it --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
Member
|
🎉 This PR is included in v1.35.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gloas containers and minimal change to gloas type.
All remaining gloas type update will be in the next PR
Part of #8439