chore: sync PeerDAS dashboard #8443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Summary of ChangesHello @twoeths, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Contributor
There was a problem hiding this comment.
Code Review
This pull request syncs an in-progress PeerDAS Grafana dashboard. The changes involve a major reorganization of the dashboard, with panels being added, removed, and modified. While the new dashboard structure looks reasonable, I've found a few issues. There's a minor typo in a legend and some extraneous whitespace in a query. More critically, several panels use Prometheus metrics that do not seem to be defined in the provided metrics files, or use incorrect prefixes (e.g., beacon_ for custom metrics). This will cause those panels to fail to display data. Please ensure all metrics are correctly named and implemented before this is merged.
Comment on lines
594
to
607
| "targets": [ | ||
| { | ||
| "datasource": { | ||
| "type": "prometheus", | ||
| "uid": "${DS_PROMETHEUS}" | ||
| }, | ||
| "editorMode": "code", | ||
| "expr": "avg_over_time(\n (rate(beacon_data_column_sidecar_processing_requests_total[1m]) * 12 > 0)[$rate_interval:]\n)\n-\navg_over_time(\n (rate(beacon_data_column_sidecar_processing_successes_total[1m]) * 12 > 0)[$rate_interval:]\n) != 0", | ||
| "format": "time_series", | ||
| "interval": "", | ||
| "intervalFactor": 1, | ||
| "legendFormat": "{{instance}}", | ||
| "expr": "rate(lodestar_gossip_data_column_received_to_gossip_validate_seconds_bucket[$rate_interval])", | ||
| "instant": false, | ||
| "legendFormat": "__auto", | ||
| "range": true, | ||
| "refId": "A" | ||
| } | ||
| ], |
Contributor
There was a problem hiding this comment.
The metric lodestar_gossip_data_column_received_to_gossip_validate_seconds_bucket used in this query is not defined in packages/beacon-node/src/metrics/metrics/lodestar.ts. This panel will likely fail to show data.
Member
There was a problem hiding this comment.
@twoeths this seems correct, the metric doesn't exist
Contributor
Author
There was a problem hiding this comment.
yes I think we need to revise based on each of the comment here, all seems legit
Comment on lines
761
to
776
| "targets": [ | ||
| { | ||
| "datasource": { | ||
| "type": "prometheus", | ||
| "uid": "${DS_PROMETHEUS}" | ||
| }, | ||
| "editorMode": "code", | ||
| "exemplar": false, | ||
| "expr": "rate(beacon_engine_getBlobsV2_requests_total[$rate_interval])", | ||
| "format": "time_series", | ||
| "expr": "rate(beacon_data_column_sidecar_gossip_verification_seconds_bucket [$rate_interval])\n", | ||
| "format": "heatmap", | ||
| "instant": false, | ||
| "interval": "", | ||
| "intervalFactor": 1, | ||
| "legendFormat": "{{instance}}", | ||
| "range": true, | ||
| "refId": "A" | ||
| } | ||
| ], |
Contributor
There was a problem hiding this comment.
The query in this panel uses the metric beacon_data_column_sidecar_gossip_verification_seconds_bucket. This appears to be a custom Lodestar metric, but is prefixed with beacon_ which is for standard metrics. It should likely be lodestar_.... Also, this metric is not defined in packages/beacon-node/src/metrics/metrics/lodestar.ts. The panel will likely fail to show data.
| "interval": "", | ||
| "intervalFactor": 1, | ||
| "legendFormat": "{{instance}}", | ||
| "legendFormat": "befor verification", |
Contributor
There was a problem hiding this comment.
There's a typo in the legendFormat. "befor" should be "before".
Suggested change
| "legendFormat": "befor verification", | |
| "legendFormat": "before verification", |
| "exemplar": false, | ||
| "expr": "rate(beacon_engine_getBlobsV2_requests_total[$rate_interval])", | ||
| "format": "time_series", | ||
| "expr": "rate(beacon_data_column_sidecar_gossip_verification_seconds_bucket [$rate_interval])\n", |
Contributor
There was a problem hiding this comment.
This PromQL query contains extra whitespace before [$rate_interval]. While Prometheus may handle this, it's best to remove it for clarity and consistency.
Suggested change
| "expr": "rate(beacon_data_column_sidecar_gossip_verification_seconds_bucket [$rate_interval])\n", | |
| "expr": "rate(beacon_data_column_sidecar_gossip_verification_seconds_bucket[$rate_interval])\n", |
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
approved these changes
Sep 22, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8443 +/- ##
=========================================
Coverage 52.24% 52.25%
=========================================
Files 853 853
Lines 64770 64770
Branches 4766 4766
=========================================
+ Hits 33841 33844 +3
+ Misses 30859 30856 -3
Partials 70 70 🚀 New features to boost your workflow:
|
wemeetagain
approved these changes
Sep 22, 2025
Member
|
🎉 This PR is included in v1.35.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description