-
-
Notifications
You must be signed in to change notification settings - Fork 414
chore: add bun exports to packages #8448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @wemeetagain, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's compatibility with the Bun JavaScript runtime by introducing specific Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the Bun runtime by introducing a "bun" export condition in the package.json files across multiple packages. This change enables Bun to directly consume TypeScript source files, which is a significant enhancement for development workflows. The modifications are consistently applied and correctly structured within the exports map. The addition of a new lodestar.ts binary for Bun is also a logical step. The changes appear correct and well-implemented.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8448 +/- ##
============================================
- Coverage 52.25% 52.24% -0.01%
============================================
Files 853 853
Lines 64770 64770
Branches 4768 4766 -2
============================================
- Hits 33844 33841 -3
- Misses 30856 30859 +3
Partials 70 70 🚀 New features to boost your workflow:
|
Performance Report✔️ no performance regression detected Full benchmark results
|
**Motivation** - #7280 **Description** - combined with #8448, `surpressTranspileTS: true` is needed for workers to use typescript source directly without transpiling it (and incorrectly loading it via a commonjs loader) - avoid worker `resourceLimits` - Bun doesn't implement it, it throws if you use it - use `datastore-fs` instead of `datastore-level` for backing our libp2p database -- Note this is changed unilaterally (affecting current nodejs usage) - use assemblyscript chacha20-poly1305 - bun doesn't support the native crypto implementation
|
🎉 This PR is included in v1.35.0 🎉 |
Motivation
Description
"bun"export to all packages that points to the typescript source rather than the transpiled javascript