chore: enable organize imports for linting #8410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @nazarhussain, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request reactivates and customizes the import organization feature in the project's "biome.jsonc" configuration. The primary goal is to standardize import ordering across the codebase, which enhances code readability and ensures consistency. This change also includes fixes for any linting errors that arose from the newly enforced import rules.
Highlights
- Import Organization Re-enabled: The "organizeImports" feature in "biome.jsonc" has been switched from "off" to "on", re-activating automatic import sorting.
- Custom Import Grouping Rules: A comprehensive "groups" configuration has been added to "organizeImports", defining a specific order for various import types including Bun, Node.js, npm, URLs, libraries, aliases, and project-specific paths.
- Linting Error Resolution: All existing linting errors related to import ordering have been addressed and fixed as a result of enabling and configuring the import organization.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables and configures import organization using Biome. The configuration for grouping imports is a great addition for maintaining code consistency. However, I've noticed a small issue in the ordering of the import groups in biome.jsonc which prevents the intended behavior. The group for @chainsafe and @lodestar packages is placed after the general package group, making it ineffective. I've suggested a correction to the group order to fix this.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #8410 +/- ##
============================================
- Coverage 52.26% 52.24% -0.02%
============================================
Files 853 853
Lines 64784 64770 -14
Branches 4766 4766
============================================
- Hits 33858 33841 -17
- Misses 30856 30859 +3
Partials 70 70 🚀 New features to boost your workflow:
|
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
ed93216 to
cc7c1b6
Compare
cc7c1b6 to
45ec19e
Compare
wemeetagain
reviewed
Sep 19, 2025
biome.jsonc
Outdated
| "npm:*", | ||
| "npm:*/**" | ||
| ], | ||
| ["@chainsafe/**", "@lodestar/**", "@/**"], |
Member
There was a problem hiding this comment.
I think we want:
- node/bun modules
- external packages
@lodestarpackages- internal imports
- paths
wemeetagain
approved these changes
Sep 19, 2025
Member
|
🎉 This PR is included in v1.35.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Enable the organize import back which was disabled in #7982 to isolate the changes for import ordering
Description
Steps to test or reproduce