chore: revise epoch transition metric bucket #8361
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @twoeths, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request aims to enhance the monitoring and understanding of epoch transition performance by refining existing metrics and introducing new logging. The changes ensure that the collected data more accurately reflects real-world performance, enabling better analysis and optimization of critical blockchain processes.
Highlights
- Metric Bucket Revision: The buckets for
lodestar_stfn_epoch_transition_secondsandlodestar_precompute_next_epoch_transition_duration_secondsmetrics have been updated to reflect more realistic epoch transition times, removing very low, unrealistic values and adding higher, more relevant ones. - Epoch Transition Duration Logging: The
prepareNextSlot.tsfile now logs the duration of the epoch transition, providing more detailed insights into its performance.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the metric buckets for epoch transition duration to provide more realistic and detailed measurements, and also introduces logging for this duration. The changes align well with the stated goals. My feedback focuses on improving the precision and reliability of the new duration logging.
| const precomputeEpochTransitionTimer = isEpochTransition | ||
| ? this.metrics?.precomputeNextEpochTransition.duration.startTimer() | ||
| : null; | ||
| const start = Date.now(); |
There was a problem hiding this comment.
For measuring durations, process.hrtime.bigint() is generally preferred over Date.now(). Date.now() is based on the system clock, which can be adjusted (e.g., by NTP), potentially leading to inaccurate or even negative durations. process.hrtime.bigint() provides a monotonic, high-resolution timer that is not affected by system time changes. You'll need to update the duration calculation accordingly where this start variable is used.
| const start = Date.now(); | |
| const start = process.hrtime.bigint(); |
| headSlot, | ||
| prepareSlot, | ||
| previousHits, | ||
| durationMs: Date.now() - start, |
There was a problem hiding this comment.
To align with the change from Date.now() to process.hrtime.bigint(), this duration calculation should be updated. process.hrtime.bigint() returns nanoseconds, so it needs to be converted to milliseconds for the log.
| durationMs: Date.now() - start, | |
| durationMs: Number(process.hrtime.bigint() - start) / 1_000_000, |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## unstable #8361 +/- ##
=========================================
Coverage 54.09% 54.09%
=========================================
Files 850 850
Lines 64193 64195 +2
Branches 4855 4854 -1
=========================================
+ Hits 34723 34725 +2
Misses 29393 29393
Partials 77 77 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in v1.35.0 🎉 |
Motivation
Description
lodestar_precompute_next_epoch_transition_duration_seconds