fix: correct leveldb metrics #8355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Motivation** - misuse `dbRead*` vs `dbWrite*` which leads to incorrect metric **Description** - this PR should ideally be with `unstable` target branch, however leaving here so that we can investigate #8334 easier - we will merge this to unstable later anyway part of #8334 Co-authored-by: Tuyen Nguyen <twoeths@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @nflaig, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses an issue where database read operations were being incorrectly reported as write operations in the LevelDB metrics. The change ensures that the metrics accurately reflect read requests and the number of items read, improving the reliability of monitoring for database interactions.
Highlights
- Metric Correction: Corrected LevelDB metrics to accurately reflect read operations instead of write operations for
db.iterator,db.keys, anddb.values .all()calls.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in LevelDB metrics by correcting the counters used for read operations. The changes in packages/db/src/controller/level.ts ensure that methods for reading data from the database, such as keys, values, and entries (both batch and streaming versions), now correctly increment dbReadReq and dbReadItems instead of the write-related metrics. The fix is accurate and well-targeted, and the code quality is good. I have no further recommendations.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## unstable #8355 +/- ##
=========================================
Coverage 54.07% 54.07%
=========================================
Files 849 849
Lines 64126 64126
Branches 4852 4853 +1
=========================================
+ Hits 34674 34677 +3
+ Misses 29375 29372 -3
Partials 77 77 🚀 New features to boost your workflow:
|
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Sep 8, 2025
Member
|
🎉 This PR is included in v1.35.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring #8335 to unstable