-
-
Notifications
You must be signed in to change notification settings - Fork 414
fix: add bucketId to all db operations #8347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## unstable #8347 +/- ##
=========================================
Coverage 54.07% 54.07%
=========================================
Files 849 849
Lines 64126 64141 +15
Branches 4852 4852
=========================================
+ Hits 34674 34684 +10
- Misses 29375 29380 +5
Partials 77 77 🚀 New features to boost your workflow:
|
Member
Author
wemeetagain
approved these changes
Sep 8, 2025
Member
|
🎉 This PR is included in v1.35.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Similar to #8346 adds missing
bucketIdto all db operations to avoidunknownThis is from
stable-lg1k-hzax41-dkrwhich shows it's already an issue thereDescription
Add
bucketIdto all db operationsdeployed to
feat3to make sure I didn't miss anything