forked from pimcore/pimcore
-
Notifications
You must be signed in to change notification settings - Fork 0
re-added support for animated gif thumbnails #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zoidbergx
wants to merge
1
commit into
6.9
Choose a base branch
from
re-add-animated-gif-thumbnails
base: 6.9
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juckerf
pushed a commit
that referenced
this pull request
Jan 30, 2023
* Do not initialize db schema in constructor. * Do not initialize db schema in constructor. * Always remove schema. * Always return schema. * Fix phpstan test (#1) * Fix phpstan * Add ConnectionInterface::getSchemaManager() * Remove unused use * Code improvements. * Revert changes regarding connection interface. * Add method annotation to simplify code in getSchema() Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de>
juckerf
pushed a commit
that referenced
this pull request
Jan 30, 2023
… deprecated ResourceBundle::getLocales(): Passing null to parameter #1 ($bundle) of type string is deprecated in PHP 8.1
juckerf
pushed a commit
that referenced
this pull request
Jan 30, 2023
…s deprecate (pimcore#12458) * [PHP 8.1] fix Passing null to parameter #1 ($string) of type string is deprecate https://github.com/coreshop/CoreShop/runs/6981738951?check_suite_focus=true#step:17:93 * Update Staticroute.php * Update Staticroute.php * Update Staticroute.php * Update models/Staticroute.php Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de> Co-authored-by: Bernhard Rusch <brusch@users.noreply.github.com> Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de>
juckerf
pushed a commit
that referenced
this pull request
Jan 30, 2023
… Passing null to parameter #1 ($string) of type string is deprecated" when calling it with null (pimcore#12839)
juckerf
pushed a commit
that referenced
this pull request
Jan 30, 2023
Example error message:
Warning: Undefined array key "localizedfields"
Es ist eine Ausnahme aufgetreten - der Vorgang konnte nicht durchgeführt werden. Bitte laden Sie die Adminoberfläche neu und versuchen Sie es danach erneut.Timestamp: Wed Nov 09 2022 16:06:23 GMT+0100 (Mitteleuropäische Normalzeit) Status: 500 | Internal Server Error URL: /admin/object-helper/grid-get-column-config Message: Warning: Undefined array key "localizedfields" Trace: in /var/www/html/vendor/pimcore/pimcore/models/DataObject/Service.php:1263 #0 /var/www/html/vendor/pimcore/pimcore/bundles/AdminBundle/Controller/Admin/DataObject/DataObjectHelperController.php(257): Pimcore\Model\DataObject\Service::getCustomGridFieldDefinitions('subscription', 49356) #1 /var/www/html/vendor/pimcore/pimcore/bundles/AdminBundle/Controller/Admin/DataObject/DataObjectHelperController.php(225): Pimcore\Bundle\AdminBundle\Controller\Admin\DataObject\DataObjectHelperController->doGetGridColumnConfig(Object(Symfony\Component\HttpFoundation\Request), Object(Pimcore\Config)) #2 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(153): Pimcore\Bundle\AdminBundle\Controller\Admin\DataObject\DataObjectHelperController->gridGetColumnConfigAction(Object(Symfony\Component\HttpFoundation\Request), Object(Pimcore\Config)) #3 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(75):
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) #4 /var/www/html/vendor/symfony/http-kernel/Kernel.php(202): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #5 /var/www/html/public/index.php(40): Symfony\Component\HttpKernel\Kernel->handle(Object(Symfony\Component\HttpFoundation\Request)) #6 {main}
juckerf
pushed a commit
that referenced
this pull request
Jan 30, 2023
…ype string is deprecated" (pimcore#13828)
juckerf
pushed a commit
that referenced
this pull request
Jan 30, 2023
…f type resource, null given Folder Preview $tileThumb->getStream can return null
zoidbergx
pushed a commit
that referenced
this pull request
Aug 15, 2023
…when uploading video (pimcore#15621) * Fix: Ceil():Argument #1 ($num) must be of type int|float, null given when uploading video * Fix wrong php doc. * move ceil to getDurationString() * Remove unnecessary int cast * Make getDurationString non static
zoidbergx
pushed a commit
that referenced
this pull request
Aug 22, 2023
* Update Video.php Pimcore\Model\Asset\Video::getThumbnailConfig(): Argument #1 ($config) must be of type Pimcore\Model\Asset\Video\Thumbnail\Config|string, null given, called in /var/www/html/vendor/pimcore/pimcore/models/Document/Editable/Video.php on line 492 File: /var/www/html/vendor/pimcore/pimcore/models/Asset/Video.php Line: 73 * Update Video.php strpos(): Argument #1 ($haystack) must be of type string, int given File: /var/www/html/vendor/pimcore/pimcore/models/Document/Editable/Video.php Line: 938 some values arent strings
zoidbergx
pushed a commit
that referenced
this pull request
Aug 22, 2023
…of type int|float, string given
zoidbergx
pushed a commit
that referenced
this pull request
Oct 13, 2023
* Fallback to url if text is disabled Fix `htmlspecialchars(): Argument #1 ($string) must be of type string, null given` * Update models/Document/Editable/Link.php Readable code Co-authored-by: Divesh Pahuja <divesh.pahuja@pimcore.com> --------- Co-authored-by: Divesh Pahuja <divesh.pahuja@pimcore.com>
zoidbergx
pushed a commit
that referenced
this pull request
Oct 13, 2023
…core#15861) * set cpath when using AbstractElement::setProperty() * prevent error "E_DEPRECATED: strcmp(): Passing null to parameter #1 ($string1) of type string is deprecated" when cpath is NULL * fill cpath based on owner element if not set
zoidbergx
pushed a commit
that referenced
this pull request
Feb 7, 2024
Automated PR from CE repository
das-peter
pushed a commit
that referenced
this pull request
Jun 24, 2025
das-peter
pushed a commit
that referenced
this pull request
Jun 24, 2025
…aVersionTimestamp) must be of type int, null given (pimcore#18057)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure your PR complies with all of the following points:
doc/10.0(see Readme.md for the list of supported versions)Don't submit a PR if it doesn't comply, it'll be closed without a comment!
-->
Changes in this pull request
Resolves #-
Additional info