Added Libbi charge limit support #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does 'device.battery_size' return a value in kWh? so 10 for a 10kWh battery? |
|
Yes 'device.battery_size' does return a value in kWh |
|
I was checking if it was unitary values like 5 or 10 or 5000 or 10000 In your code you have kWhx10 so that result would be 50 or 100 if unitary values? |
|
The input values are unitary battery_size is in kWh multiply by 1000 to convert kWh to Wh since set_charge_target() expects the target in Wh. |
G6EJD
approved these changes
Jul 16, 2025
|
Commit Error: |
|
Github repaired the file, so all done now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Libbi charge limit support
Fixed, universal and tested version of #665