Update sensor.py #668
Merged
Update sensor.py #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added icon and state class to the two eddi temperature sensors.
G6EJD
reviewed
Jul 5, 2025
Scrolling through the class, there seems to be a mix in the functions, some with and some without a comma on the last element. An example of one without: |
|
Yes Python has its own syntactical idiosyncrasies, but it depends how the function parameters are structured. All done now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added icon and state class to the two eddi temperature sensors.
The main aim is to enable the two sensors to be available as long term statistics in Home Assistant.
Adding the icon was just coincidental, rather than specifying NONE for the icon property of the create_meta function.
Relates to issue #353.