-
Notifications
You must be signed in to change notification settings - Fork 130
feat : added task swipe tour #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@SGI-CAPP-AT2 Please review this when you get time. |
SGI-CAPP-AT2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove generated or unintended files.
PR will be gtg then.
| import path_provider_foundation | ||
| import shared_preferences_foundation | ||
| import sqflite_darwin | ||
| import sqflite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mastermind-sap are these changes intended? if not, we should discard it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this
|
Hey @SGI-CAPP-AT2 , If you still want you can ignore those generated files. |
SGI-CAPP-AT2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and runs fine !
|
@SGI-CAPP-AT2 I have updated the gitignore and removed the generated files. |
SGI-CAPP-AT2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Sorry for misunderstanding,
I wanted the files to be just discarded from that commit and not to be ignored using gitignore.
Do not add files to .gitignore instead do not stage them for commit manually
We should discuss about .gitignore changes in another issue.
6c66d5c to
870bdea
Compare
|
@SGI-CAPP-AT2 I have removed the previous commit like you asked. |
SGI-CAPP-AT2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove those generated files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this as well from commit
| import path_provider_foundation | ||
| import shared_preferences_foundation | ||
| import sqflite_darwin | ||
| import sqflite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this
|
I cannot understand why I need to do this. Anyways I have done as you said @SGI-CAPP-AT2 . |
Just to keep PR and commits clean |
61e7941 to
766b355
Compare
Description
Fixes #459
Screenshots
Checklist