这是indexloc提供的服务，不要输入任何密码
Skip to content

feat: make pkg_config linking respect FFMPEG_LINK_MODE #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2025
Merged

feat: make pkg_config linking respect FFMPEG_LINK_MODE #142

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34aa7a1
feat: make pkg_config linking respect FFMPEG_LINK_MODE
ldm0 Aug 16, 2025
66aaa37
Fix windows warning
ldm0 Aug 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,19 @@ impl callbacks::ParseCallbacks for FilterCargoCallbacks {
}
}

#[derive(Clone, Copy)]
#[derive(Clone, Copy, PartialEq, Eq)]
enum FFmpegLinkMode {
Static,
Dynamic,
}

#[cfg(not(target_os = "windows"))]
impl FFmpegLinkMode {
fn is_static(&self) -> bool {
self == &Self::Static
}
}

impl From<String> for FFmpegLinkMode {
fn from(value: String) -> Self {
match &*value {
Expand Down Expand Up @@ -333,10 +340,12 @@ mod pkg_config_linking {
/// Note: no side effect if this function errors.
pub fn linking_with_pkg_config(
library_names: &[&str],
statik: bool,
) -> Result<Vec<PathBuf>, pkg_config::Error> {
// dry run for library linking
for libname in library_names {
pkg_config::Config::new()
.statik(statik)
.cargo_metadata(false)
.env_metadata(false)
.print_system_libs(false)
Expand All @@ -348,6 +357,7 @@ mod pkg_config_linking {
let mut paths = HashSet::new();
for libname in library_names {
let new_paths = pkg_config::Config::new()
.statik(statik)
.probe(&format!("lib{}", libname))
.unwrap_or_else(|_| panic!("{} not found!", libname))
.include_paths;
Expand Down Expand Up @@ -437,7 +447,13 @@ fn linking(env_vars: EnvVars) {
output_binding_path: &Path,
) -> Result<(), pkg_config::Error> {
// Probe libraries(enable emitting cargo metadata)
let include_paths = pkg_config_linking::linking_with_pkg_config(&*LIBS)?;
let include_paths = pkg_config_linking::linking_with_pkg_config(
&*LIBS,
env_vars
.ffmpeg_link_mode
.map(|x| x.is_static())
.unwrap_or_default(),
)?;
if let Some(ffmpeg_binding_path) = env_vars.ffmpeg_binding_path.as_ref() {
use_prebuilt_binding(ffmpeg_binding_path, output_binding_path);
} else if let Some(ffmpeg_include_dir) = env_vars.ffmpeg_include_dir.as_ref() {
Expand Down
Loading