这是indexloc提供的服务，不要输入任何密码
Skip to content
This repository was archived by the owner on Sep 2, 2020. It is now read-only.

Cache common values of Task #85

Merged
merged 1 commit into from
Oct 15, 2015
Merged

Cache common values of Task #85

merged 1 commit into from
Oct 15, 2015

Conversation

@grantland
Copy link
Member

@grantland grantland commented Sep 3, 2015

  • null
  • true|false
  • cancelled

resolves #82

@grantland
Copy link
Member Author

grantland commented Sep 3, 2015

Depends on #84

nlutsenko
nlutsenko reviewed Oct 6, 2015
View reviewed changes
Bolts/src/main/java/bolts/Task.java Outdated
Copy link
Member

@nlutsenko nlutsenko Oct 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of these, since in different languages they translate to different things, maybe rename to TASK_TRUE, etc?

@nlutsenko nlutsenko assigned grantland and unassigned nlutsenko Oct 6, 2015
@grantland grantland assigned nlutsenko and unassigned grantland Oct 14, 2015
@grantland
Copy link
Member Author

grantland commented Oct 14, 2015

@nlutsenko updated

@nlutsenko nlutsenko assigned grantland and unassigned nlutsenko Oct 15, 2015
@nlutsenko
Copy link
Member

nlutsenko commented Oct 15, 2015

Looks great!

Offtopic: Forgive me my lack of Java knowledge - what does generic type ? mean?

@grantland
Copy link
Member Author

grantland commented Oct 15, 2015

? are wildcard generics. Usage-wise Task<?> is the same as Task, but it explicitly shows that you're purposely allowing any generic type as opposed to it being a mistake.

@grantland
Cache common values of Task
514e86f 
* `null`
* `true`|`false`
* cancelled
grantland added a commit that referenced this pull request Oct 15, 2015
@grantland
Merge pull request #85 from BoltsFramework/grantland.cache
de55d7a 
Cache common values of Task
@grantland grantland merged commit de55d7a into master Oct 15, 2015
@grantland grantland deleted the grantland.cache branch October 15, 2015 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@grantland grantland

Labels

accepted CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Return a immutable singleton for Task.forResult(null) and Task.cancelled()

4 participants

@grantland @nlutsenko @facebook-github-bot