This repository was archived by the owner on Sep 2, 2020. It is now read-only.
Implement bolts.TaskCompletionSource, deprecate bolts.Task.TaskCompletionSource #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionSource Removes the weird syntax: ```java // Before: Task<Void>.TaskCompletionSource tcs = Task.create(); // After: TaskCompletionSource<Void> tcs = Task.create(); TaskCompletionSource<Void> tcs = new TaskCompletionSource<>(); ``` Deprecated APIs: `bolts.Task<TResult>.TaskCompletionSource` `bolts.Task.create()` New APIs: `bolts.TaskCompletionSource<TResult>` (new class, same methods as from `bolts.Task<TResult>.TaskCompletionSource`) `new bolts.TaskCompletionSource<>()` The constructor is so that we don't always have to use `Task.create()` which creates the anonymous inner class bs.
Member
There was a problem hiding this comment.
Not sure if intentional or not...
Member
|
This is awesome! |
Member
Author
|
|
|
Looks fine to me. Seems like a breaking change? ( |
Member
Author
|
@hallucinogen how does that break? TaskCompletionSource<Void> tcs = Task.create();
Task<Void>.TaskCompletionSource tcs = Task.create();I've also added a unit test to ensure this. |
Member
Author
|
@depoll it'd be great to get your opinion on this when you can 😄 |
grantland
added a commit
that referenced
this pull request
Sep 30, 2015
Implement bolts.TaskCompletionSource, deprecate bolts.Task.TaskCompletionSource
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the weird syntax:
Deprecated APIs:
bolts.Task<TResult>.TaskCompletionSourcebolts.Task.create()New APIs:
bolts.TaskCompletionSource<TResult>(new class, same methods as frombolts.Task<TResult>.TaskCompletionSource)new bolts.TaskCompletionSource<>()The constructor is so that we don't always have to use
Task.create()which creates the anonymous inner class bs.