fix(logout): should work correctly with multiple tabs (release) #1435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wermanoid
commented
Aug 8, 2024
| @@ -72,23 +84,13 @@ const sendMessageAsync = | |||
| messageChannel.port1.close(); | |||
| messageChannel.port2.close(); | |||
| }; | |||
| registration.active.postMessage(data, [messageChannel.port2]); | |||
| registration.active.postMessage({ ...data, tabId: getTabId(data.configurationName) }, [ | |||
There was a problem hiding this comment.
this was very annoying that some actions has tabId and some are missing. I decided to unify this piece, so any interaction between client(s)/serviceWorker will hold ID for identification which tab performs specific action
There was a problem hiding this comment.
Thank you @wermanoid , very sorry for the delay. I am in holidays :)
There was a problem hiding this comment.
I can publish it as an alpha if you want ?
There was a problem hiding this comment.
sure, let's do it :)
thanks!
There was a problem hiding this comment.
Published as an alpha @wermanoid thank you !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
If you have
allowMultiTabLoginand you have few tabs opened, you can face issue with logout function.As I found, after logout there are still couple of messages sent from client to serwiceWorker (init and setState, at least).
This leads to case, when
currentDatabase.stateis changed after you passed logout function, but before you get redirected back to login screen. (At lease I think this is a reason. If you have better ideas about how to fix this - please comment, this is interesting).So when you try to login after logout, you receive 400 error from OAuth2 server, because client sends request with some data from previous session (which was closed obviously).
After this PR
You can loggin back to app from any tab without errors