这是indexloc提供的服务，不要输入任何密码
Skip to content

Update lint-staged 15.4.1 → 15.5.0 (minor) #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update lint-staged 15.4.1 → 15.5.0 (minor) #144

wants to merge 1 commit into from

Conversation

@depfu
Copy link

@depfu depfu bot commented Mar 13, 2025 •
edited
Loading

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ lint-staged (15.4.1 → 15.5.0) · Repo · Changelog

Release Notes

15.5.0

Minor Changes

  • #1526 630af5f Thanks @iiroj! - Lint-staged no longer resets to the original state when preventing an empty git commit. This happens when your configured tasks reset all the staged changes, typically when trying to commit formatting changes which conflict with your linter setup like ESLint or Prettier.

    Example with Prettier

    By default Prettier prefers double quotes.

    Previously

    1. Stage file.js with only double quotes " changed to '
    2. Run git commit -am "I don't like double quotes"
    3. Lint-staged runs prettier --write file.js, converting all the ' back to "
    4. Because there are now no changes, lint-staged fails, cancels the commit, and resets back to the original state
    5. Commit was not done, original state is restored and single quotes ' are staged

    Now

    1. Stage file.js with only double-quotes " changed to '
    2. Run git commit -am "I don't like double quotes"
    3. Lint-staged runs prettier --write file.js, converting all the ' back to "
    4. Because there are now no changes, lint-staged fails and cancels the commit
    5. Commit was not done, and there are no staged changes

15.4.3

Patch Changes

  • #1512 cbfed1d Thanks @tarik02! - Adjust TypeScript types for the default export so that it can be used as a value without error TS2693.

15.4.2

Patch Changes

  • #1509 8827ebf Thanks @iiroj! - Change lint-staged's dependencies to use caret (^) ranges instead of tilde (~). This makes it easier for package managers to perform dependency management when minor-level updates are also permitted instead of just patch-level.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 16 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

Summary by Sourcery

Updates lint-staged from version 15.4.1 to 15.5.0.

Enhancements:

  • Prevents lint-staged from resetting to the original state when preventing an empty git commit, which can occur when configured tasks reset all staged changes.
  • Updates dependencies to use caret ranges instead of tilde ranges, which makes it easier for package managers to perform dependency management when minor-level updates are also permitted instead of just patch-level.

@depfu depfu bot added the depfu label Mar 13, 2025
@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Mar 13, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@codesandbox
Copy link

codesandbox bot commented Mar 13, 2025

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 13, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This pull request updates the lint-staged dependency from version 15.4.1 to 15.5.0. It also includes updates to the commander and yaml dependencies, and removes the apps/docs configuration. The lint-staged update includes a change that prevents lint-staged from resetting to the original state when preventing an empty git commit.

Sequence diagram for lint-staged preventing empty commit

sequenceDiagram
    participant User
    participant git
    participant lint-staged
    participant prettier

    User->>git: Stage file.js (double quotes changed to single quotes)
    User->>git: Run git commit -am "I don't like double quotes"
    git->>lint-staged: pre-commit hook
    lint-staged->>prettier: prettier --write file.js (single quotes changed back to double quotes)
    prettier-->>lint-staged: No changes
    lint-staged->>git: Fail and cancel commit
    git->>User: Commit not done, no staged changes
Loading

File-Level Changes

Change Details Files
Updated the lint-staged dependency from version 15.4.1 to 15.5.0.
  • Updated the lint-staged version in pnpm-lock.yaml.
  • Updated the lint-staged version in package.json.
 pnpm-lock.yaml
package.json
Removed the apps/docs configuration from pnpm-lock.yaml.
  • Removed the apps/docs entry and its associated dependencies and devDependencies.
 pnpm-lock.yaml
Updated the version of the commander dependency.
  • Updated the commander version from 12.1.0 to 13.1.0 in pnpm-lock.yaml.
 pnpm-lock.yaml
Updated the version of the yaml dependency.
  • Updated the yaml version from 2.6.1 to 2.7.0 in pnpm-lock.yaml.
 pnpm-lock.yaml
Modified the apps/web/package.json file.
  • Removed unnecessary whitespace.
 apps/web/package.json
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Mar 13, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, depfu[bot]!). We assume it knows what it's doing!

@depfu depfu bot mentioned this pull request Mar 13, 2025
Closed
@depfu depfu bot force-pushed the depfu/update/pnpm/lint-staged-15.5.0 branch from 24e173d to 7f169eb Compare March 23, 2025 22:05
@qodo-merge-pro
Copy link

qodo-merge-pro bot commented Mar 23, 2025 •
edited
Loading

CI Feedback 🧐

(Feedback updated until commit 7f169eb)

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: Build and Test

Failed stage: Setup pnpm [❌]

Failure summary:

The action failed due to two distinct issues:

1. PNPM setup failure (lines 151-162): There's a version conflict between:
- latest version
specified in the GitHub Action config
- pnpm@9.0.0 specified in the package.json packageManager
field
This causes a version mismatch error.

2. Codecov test results action failure (line 191): No JUnit XML test result files were found for
upload. The system searched for test result files but found 0 files to report.

Relevant error logs: 
1:  ##[group]Operating System
2:  Ubuntu
...

136:  ##[endgroup]
137:  ##[warning]Cache not found for keys: Linux-turbo-ddf568e9bde3016199b708b7cfdaa1e7ad5c68bd, Linux-turbo-
138:  Cache not found for input keys: Linux-turbo-ddf568e9bde3016199b708b7cfdaa1e7ad5c68bd, Linux-turbo-
139:  ##[group]Run pnpm/action-setup@v4.0.0
140:  with:
141:  version: latest
142:  dest: ~/setup-pnpm
143:  run_install: null
144:  package_json_file: package.json
145:  standalone: false
146:  env:
147:  TURBO_TOKEN: 
148:  TURBO_TEAM: 
149:  ##[endgroup]
150:  ##[group]Running self-installer...
151:  Error: Multiple versions of pnpm specified:
152:  - version latest in the GitHub Action config with the key "version"
153:  - version pnpm@9.0.0 in the package.json with the key "packageManager"
154:  Remove one of these versions to avoid version mismatch errors like ERR_PNPM_BAD_PM_VERSION
155:  at readTarget (/home/runner/work/_actions/pnpm/action-setup/v4.0.0/dist/index.js:1:4528)
156:  at runSelfInstaller (/home/runner/work/_actions/pnpm/action-setup/v4.0.0/dist/index.js:1:3742)
157:  at async install (/home/runner/work/_actions/pnpm/action-setup/v4.0.0/dist/index.js:1:2976)
158:  at async main (/home/runner/work/_actions/pnpm/action-setup/v4.0.0/dist/index.js:1:444)
159:  ##[error]Error: Multiple versions of pnpm specified:
160:    - version latest in the GitHub Action config with the key "version"
161:    - version pnpm@9.0.0 in the package.json with the key "packageManager"
162:  Remove one of these versions to avoid version mismatch errors like ERR_PNPM_BAD_PM_VERSION
163:  ##[group]Run codecov/test-results-action@v1.0.2
...

176:  gpg: Total number processed: 1
177:  gpg:               imported: 1
178:  gpg: Signature made Wed Mar 12 16:00:55 2025 UTC
179:  gpg:                using RSA key 27034E7FDB850E0BBC2C62FF806BB28AED779869
180:  gpg: Good signature from "Codecov Uploader (Codecov Uploader Verification Key) <security@codecov.io>" [unknown]
181:  gpg: WARNING: This key is not certified with a trusted signature!
182:  gpg:          There is no indication that the signature belongs to the owner.
183:  Primary key fingerprint: 2703 4E7F DB85 0E0B BC2C  62FF 806B B28A ED77 9869
184:  ==> Uploader SHASUM verified (39dd112393680356daf701c07f375303aef5de62f06fc80b466b5c3571336014  codecov)
185:  ==> Running version latest
186:  ==> Running version v10.2.1
187:  ==> Running command '/home/runner/work/_actions/codecov/test-results-action/v1.0.2/dist/codecov do-upload'
188:  [command]/home/runner/work/_actions/codecov/test-results-action/v1.0.2/dist/codecov do-upload -C 7f169eb78e2a1d879e2899d20dbcdf08c3272547 --report-type test_results
189:  info - 2025-03-23 22:05:41,098 -- ci service found: github-actions
190:  info - 2025-03-23 22:05:41,140 -- Found 0 test_results files to report
191:  error - 2025-03-23 22:05:41,141 -- No JUnit XML reports found. Please review our documentation (https://docs.codecov.com/docs/test-result-ingestion-beta) to generate and upload the file.
192:  info - 2025-03-23 22:05:41,639 -- No test results reports found. Triggering notifications without uploading.

@depfu
Copy link
Author

depfu bot commented Apr 12, 2025

Closed in favor of #160.

@depfu depfu bot closed this Apr 12, 2025
@depfu depfu bot deleted the depfu/update/pnpm/lint-staged-15.5.0 branch April 12, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

depfu size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants