fix: Debian packages with tar.gz data file #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Debian package has a data file that's already compressed with gz and named data.tar.gz it fails with Error in genrule: rule 'data' has file 'data.tar.gz' as both an input and an output. See issue GoogleContainerTools#98
|
It passes all the current tests and I've manually tested it in a development branch with one of the problematic CUDA packages. This fix seems to work and the CUDA packages don't fail like they did before. However, I can't get that test to pass as it fails on yet-another issue that I'm trying to debug. Still, I think the diff is easy to follow and I think it's good to go. |
jjmaestro
added a commit
to jjmaestro/rules_distroless
that referenced
this pull request
Sep 20, 2024
|
@thesayyn I think this fix should go first and then I'll rebase the refactor and other branches. What do you think? |
thesayyn
approved these changes
Sep 21, 2024
|
Bear with me as i work through these PRs :) FYI It may take days/weeks. |
|
@thesayyn of course!! no worries :) I'll keep the PRs rebased and up-to-date! |
jjmaestro
added a commit
to jjmaestro/rules_distroless
that referenced
this pull request
Dec 16, 2024
Fixes GoogleContainerTools#141 In GoogleContainerTools#99 I added a dependency to basename when it's not really needed. Credit and thanks to @birunts for finding the dependency and providing a potential solution!
This was referenced Dec 16, 2024
jjmaestro
added a commit
to jjmaestro/rules_distroless
that referenced
this pull request
Dec 17, 2024
Fixes GoogleContainerTools#141 In GoogleContainerTools#99 I added a dependency to basename when it's not really needed. Credit and thanks to @birunts for finding the issue and providing the solution!
jjmaestro
added a commit
to jjmaestro/rules_distroless
that referenced
this pull request
Jan 21, 2025
Fixes GoogleContainerTools#141 In GoogleContainerTools#99 I added a dependency to basename when it's not really needed. Credit and thanks to @birunts for finding the issue and providing the solution!
thesayyn
pushed a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Debian package has a data file that's already compressed with
gzipand nameddata.tar.gzit fails with:See issue #98