refactor: improve copy.sh #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
17862ed to
0afb5dc
Compare
|
@thesayyn could you continue reviewing the stack of PRs? 😅 🙏 this one and the previous 3 PRs in the stack (87, 88, and 91) should be very easy to review, they add a few things before the larger refactors. Thanks!! |
97c2331 to
05914ac
Compare
thesayyn
reviewed
Nov 13, 2024
* separate the script into a template file so it's easier to shellcheck
and syntax highlight in editors.
* shellcheck the script and remove all SC2086 warnings
("Double quote to prevent globbing and word splitting")
* improve the buildozer help messages in the copy.sh script:
* reduce duplication of buildozer command
* add a more clear autofix bazel run command that can be easily
copy-pasted
* change some of the variable names in the copy.sh template for longer,
easier to understand names (repo_name >> name, lock_label >> label)
* move repo_name and workspace_relative_path into variables to reduce
line length and improve readability
05914ac to
95ad300
Compare
|
@thesayyn I think I've addressed the issue in your review re. the P.S. I've also rebased all of the other branches so they should be ready for review too :) |
thesayyn
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Stacked on top of #91
refactor: improve the lock copy.sh script
separate the script into a template file so it's easier to shellcheck and syntax highlight in editors.
shellcheck the script and remove all SC2086 warnings ("Double quote to prevent globbing and word splitting")
improve the buildozer help messages in the copy.sh script:
change some of the variable names in the copy.sh template for longer, easier to understand names (repo_name >> name, lock_label >> label)
move repo_name and workspace_relative_path into variables to reduce line length and improve readability