-
Notifications
You must be signed in to change notification settings - Fork 51
feat: Support initial empty lockfile #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support initial empty lockfile #160
Conversation
Signed-off-by: Nahuel Espinosa <nahue.espinosa@gmail.com>
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Some CI steps are failing, do you mind checking them? |
Signed-off-by: Nahuel Espinosa <nahue.espinosa@gmail.com>
Tests are passing locally now! |
Signed-off-by: Nahuel Espinosa <nahue.espinosa@gmail.com>
Thanks for the improvement! If the lock file doesn't exist (initial), why wouldn't the rule start from empty instead of still requiring user to create the initial empty file? |
Maybe something like this?
|
Submitted PR #169 |
When setting up a new project, an initial template is required for lockfile generation to work without errors.
This patch allows users to create an empty file and run, for example:
bazel run @bullseye//:lock
.Related to GoogleContainerTools/distroless#1697.